Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar, punctuation, duplications in Knowledge Base #1473

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

d4rklynk
Copy link
Contributor

@d4rklynk d4rklynk commented Jun 22, 2022

As English is not my main language, I probably did some mistakes.

Note :

  • "third party" changed to "third-party" same goes for open-source and closed-source

Every rules of grammar/punctuation have been check (by me) for every grammar/punctuation I fixed. So if you have a doubt, just ask me why I did it as I did it for a reason. That said, I probably did mistakes.

@d4rklynk d4rklynk temporarily deployed to preview June 22, 2022 12:26 Inactive
@github-actions
Copy link

github-actions bot commented Jun 22, 2022

🎊 PR Preview 3ab5a28 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1473.surge.sh

🕐 Build time: 134.565s

🤖 By surge-preview

@d4rklynk d4rklynk temporarily deployed to preview June 22, 2022 12:34 Inactive
@d4rklynk d4rklynk changed the title Fix grammar, punctuations in Knowledge Base Fix grammar, punctuations, duplication in Knowledge Base Jun 22, 2022
@d4rklynk d4rklynk changed the title Fix grammar, punctuations, duplication in Knowledge Base Fix grammar, punctuations, duplications in Knowledge Base Jun 22, 2022
@dngray dngray added c:guides full-length guides and content t:correction content corrections or errors labels Jun 22, 2022
@matchboxbananasynergy
Copy link
Contributor

I'm pretty sure that "multi-factor" is the correct way to say that.

@d4rklynk
Copy link
Contributor Author

d4rklynk commented Jun 22, 2022

I'm pretty sure that "multi-factor" is the correct way to say that.

I just changed it in case it wasn't

On Microsoft Doc, they say both x)

@matchboxbananasynergy
Copy link
Contributor

8dac5f5 You are adding back the motto that we just removed here.

@d4rklynk
Copy link
Contributor Author

8dac5f5 You are adding back the motto that we just removed here.

I probably did shit with branches

@d4rklynk d4rklynk temporarily deployed to preview June 22, 2022 21:00 Inactive
@d4rklynk d4rklynk temporarily deployed to preview June 22, 2022 21:03 Inactive
@d4rklynk d4rklynk temporarily deployed to preview June 22, 2022 21:06 Inactive
@matchboxbananasynergy
Copy link
Contributor

On "third party" vs "third-party":

https://grammarhow.com/third-party-or-third-party/

@d4rklynk d4rklynk marked this pull request as draft June 22, 2022 23:11
@d4rklynk d4rklynk temporarily deployed to preview June 23, 2022 00:10 Inactive
@d4rklynk d4rklynk temporarily deployed to preview June 23, 2022 00:13 Inactive
@d4rklynk d4rklynk changed the title Fix grammar, punctuations, duplications in Knowledge Base Fix grammar, punctuation, duplications in Knowledge Base Jun 23, 2022
@d4rklynk d4rklynk temporarily deployed to preview June 23, 2022 15:07 Inactive
@d4rklynk d4rklynk temporarily deployed to preview June 23, 2022 15:15 Inactive
@d4rklynk d4rklynk temporarily deployed to preview June 23, 2022 15:17 Inactive
@d4rklynk d4rklynk temporarily deployed to preview June 23, 2022 15:20 Inactive
@dngray dngray temporarily deployed to preview June 23, 2022 16:52 Inactive
@d4rklynk d4rklynk temporarily deployed to preview June 25, 2022 07:50 Inactive
@d4rklynk d4rklynk temporarily deployed to preview June 25, 2022 10:08 Inactive
@d4rklynk d4rklynk marked this pull request as ready for review June 25, 2022 10:15
@dngray dngray temporarily deployed to preview June 26, 2022 15:38 Inactive
@dngray dngray temporarily deployed to preview June 26, 2022 18:29 Inactive
@dngray
Copy link
Member

dngray commented Jun 26, 2022

LGTM.

Signed-off-by: Daniel Gray <dng@disroot.org>
@dngray dngray merged commit 3ab5a28 into privacyguides:main Jun 26, 2022
@dngray dngray temporarily deployed to preview June 26, 2022 18:32 Inactive
@dngray dngray temporarily deployed to production June 26, 2022 18:39 Inactive
@dngray dngray temporarily deployed to production June 26, 2022 18:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:guides full-length guides and content t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants