Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Send #1534

Closed
wants to merge 6 commits into from
Closed

Add Send #1534

wants to merge 6 commits into from

Conversation

d4rklynk
Copy link
Contributor

@d4rklynk d4rklynk commented Jul 12, 2022 •
edited by freddy-m

tracker : #494

@d4rklynk d4rklynk temporarily deployed to preview July 12, 2022 09:28 Inactive
@github-actions
Copy link

github-actions bot commented Jul 12, 2022 •
edited

🎊 PR Preview 2fad5f4 has been successfully built and deployed to https://privacyguides-privacyguides-org-preview-pr-1534.surge.sh

🕐 Build time: 104.876s

🤖 By surge-preview

kalessive
kalessive suggested changes Jul 12, 2022
View reviewed changes
Copy link

@kalessive kalessive left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a good idea to refer to the project as just 'Send' rather than 'Firefox Send Fork' since branding was intentionally removed for trademark reasons.

@d4rklynk
Copy link
Contributor Author

I think it would be a good idea to refer to the project as just 'Send' rather than 'Firefox Send Fork' as branding was intentionally removed for trademark reasons.

Agreed

@d4rklynk
Change "Firefox Send Fork" to "Send"
e89994e 
Except for firefox-send.svg in case there's another tool called "Send".
@d4rklynk d4rklynk temporarily deployed to preview July 12, 2022 11:50 Inactive
@d4rklynk d4rklynk temporarily deployed to preview July 12, 2022 11:53 Inactive
@d4rklynk d4rklynk temporarily deployed to preview July 12, 2022 12:03 Inactive
@dngray dngray added the c:software self-hosted/decentralized software and related topics label Jul 13, 2022
@matchboxbananasynergy
Copy link
Contributor

https://github.com/orgs/privacyguides/discussions/1533#discussioncomment-3166778

@freddy-m freddy-m marked this pull request as draft July 24, 2022 11:37
@freddy-m
Copy link
Member

Converting this to a draft, as we are still undecided as to whether we want to recommend this.

@freddy-m freddy-m changed the title Add Firefox Send Fork Add Send Jul 24, 2022
@dngray dngray added the pr:missing discussion PRs which add recommendations which have not yet been discussed label Jul 26, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

This hasn't been approved, wait for the "approved" label on the discussion to make a PR please.

@ghost ghost closed this Aug 9, 2022
@d4rklynk d4rklynk deleted the pr-firefox-send branch August 16, 2022 16:12
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.org/t/add-send-firefox-send-fork-to-the-file-sharing-and-sync-page/187/6

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalessive kalessive kalessive requested changes

Assignees
No one assigned
Labels
c:software self-hosted/decentralized software and related topics pr:missing discussion PRs which add recommendations which have not yet been discussed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@d4rklynk @matchboxbananasynergy @freddy-m @privacyguides-bot @kalessive @dngray