Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Hebrew, French, Dutch #2022

Merged
merged 2 commits into from Feb 26, 2023
Merged

Enable Hebrew, French, Dutch #2022

merged 2 commits into from Feb 26, 2023

Conversation

jonaharagon
Copy link
Member

@jonaharagon jonaharagon commented Feb 24, 2023 •
edited

⚠️ Do not make any changes to files in this PR!! ⚠️

Fixes for files here must be made in Crowdin and changes will be pulled from there.

Please read the warnings in the Netlify deploy log (comment below) to find translation errors.

@jonaharagon jonaharagon mentioned this pull request Feb 24, 2023
Closed
3 tasks
@netlify
Copy link

netlify bot commented Feb 24, 2023 •
edited

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit f6ca66b
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/63fb9cbb1f8760000837b623
😎 Deploy Preview https://deploy-preview-2022--privacyguides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jonaharagon jonaharagon changed the title Hebrew, French, Dutch - Test Enable Translations Feb 24, 2023
@jonaharagon jonaharagon changed the title Enable Translations Add support for translations Feb 24, 2023
@jonaharagon jonaharagon force-pushed the jonaharagon/i18n-test2 branch 2 times, most recently from f841970 to 577208d Compare February 24, 2023 22:19
jonaharagon added a commit that referenced this pull request Feb 24, 2023
@jonaharagon
Enable Hebrew, French, Dutch (#2022)
0bb2700
@jonaharagon jonaharagon changed the title Add support for translations Enable Hebrew, French, Dutch Feb 24, 2023
jonaharagon added a commit that referenced this pull request Feb 24, 2023
@jonaharagon
Enable Hebrew, French, Dutch (#2022)
b7e2e83
jonaharagon added a commit that referenced this pull request Feb 24, 2023
@jonaharagon
Enable Hebrew, French, Dutch (#2022)
3074374
jonaharagon
jonaharagon commented Feb 24, 2023
View reviewed changes
mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Outdated Show resolved Hide resolved
jonaharagon added a commit that referenced this pull request Feb 25, 2023
@jonaharagon
Enable Hebrew, French, Dutch (#2022)
769b0d6
@dngray
Copy link
Member

dngray commented Feb 25, 2023 •
edited

We want to avoid pushing a release with the translations now they've been pushed to main.

Just keep in mind I've pushed this to main 74928bb which will be there on release, even if it doesn't show exactly like that on Crowdin.

jonaharagon added a commit that referenced this pull request Feb 25, 2023
@jonaharagon @paulverbeke
Enable Hebrew, French, Dutch (#2022)
8141415 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
jonaharagon added a commit that referenced this pull request Feb 25, 2023
@jonaharagon @paulverbeke
Enable Hebrew, French, Dutch (#2022)
9231cc2 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
Enable Hebrew, French, Dutch (#2022)
2966a69 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke @dngray
Enable Hebrew, French, Dutch (#2022)
ca7bb19 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke @dngray
Enable Hebrew, French, Dutch (#2022)
00d3488 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
freddy-m
freddy-m approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to all the teams behind these translations! It's so good to see!

jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
@dngray @blacklight447
Enable Hebrew, French, Dutch (#2022)
9a239e4 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: blacklight447 <50110294+blacklight447@users.noreply.github.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
@dngray @blacklight447
Enable Hebrew, French, Dutch (#2022)
60b4e95 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: blacklight447 <50110294+blacklight447@users.noreply.github.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
@dngray @blacklight447
Enable Hebrew, French, Dutch (#2022)
17d91c5 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: blacklight447 <50110294+blacklight447@users.noreply.github.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
@dngray @blacklight447
Enable Hebrew, French, Dutch (#2022)
d86ac29 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: blacklight447 <50110294+blacklight447@users.noreply.github.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
@dngray @blacklight447
Enable Hebrew, French, Dutch (#2022)
d8d042a 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: blacklight447 <50110294+blacklight447@users.noreply.github.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
@dngray @blacklight447 @crowdin-bot
Enable Hebrew, French, Dutch (#2022)
fed7391 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: blacklight447 <50110294+blacklight447@users.noreply.github.com>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
@dngray @crowdin-bot
Enable Hebrew, French, Dutch (#2022)
756c89b 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: Niek de Wilde <niek@privacyguides.org>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
jonaharagon added a commit that referenced this pull request Feb 26, 2023
@jonaharagon @paulverbeke
@dngray @crowdin-bot
Enable Hebrew, French, Dutch (#2022)
e224dcb 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: Niek de Wilde <niek@privacyguides.org>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
@jonaharagon @paulverbeke
@dngray @crowdin-bot
Enable Hebrew, French, Dutch (#2022)
f6ca66b 
add french translations for navigation categories (#2028)

Co-Authored-By: Paul Verbeke 🇫🇷 <github.f9qel@simplelogin.com>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: Niek de Wilde 🇳🇱 <niek@privacyguides.org>
Co-authored-by: Crowdin Bot <support+bot@crowdin.com>
Co-Authored-By: fireinme 🇮🇱 <126413261+freeopensourc@users.noreply.github.com>
@jonaharagon jonaharagon merged commit f6ca66b into main Feb 26, 2023
@jonaharagon jonaharagon deleted the jonaharagon/i18n-test2 branch February 26, 2023 17:58
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-0-translations/11920/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddy-m freddy-m freddy-m approved these changes

@dngray dngray dngray approved these changes

@blacklight447 blacklight447 blacklight447 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonaharagon @dngray @privacyguides-bot @freddy-m @blacklight447