-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert pride month logos #2223
Revert pride month logos #2223
Conversation
f7d5f5c
to
7984a1a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also changes in config/layout that have to be reverted. I’d have to look at the original commit to see everything that was changed, but I can check it out when I get home.
That's okay, I checked this with a local preview build and it did seem to look alright, but I wasn't sure. |
7984a1a
to
6873326
Compare
✅ Deploy Preview for privacyguides ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I thought there were some permanent changes in ff60d62 which is why I didn't revert it in full. |
6873326
to
ed78c06
Compare
Co-Authored-By: Jonah Aragon <jonah@triplebit.net>
ed78c06
to
e906eb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought there were some permanent changes in ff60d62 which is why I didn't revert it in full.
There were, but there were also some changes to the social preview cards that needed to be reverted. Fixed!
e906eb1
to
1502f1b
Compare
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
This one I had to re-author in 1c1ecf7 as we forgot to remove the cover. If we're going to regularly do this maybe we should just have a build time variable. |
Also yeah, but I did this one pretty janky this year because mkdocs-material was missing a bunch of features that would've made this easier, which I requested and have been added in the latest version, so next time around we can do this cleanly. |
Changes proposed in this PR: