Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pride month logos #2223

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Revert pride month logos #2223

merged 1 commit into from
Jul 11, 2023

Conversation

dngray
Copy link
Member

@dngray dngray commented Jul 4, 2023

Changes proposed in this PR:

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@dngray dngray requested a review from jonaharagon July 4, 2023 06:34
dngray added a commit that referenced this pull request Jul 4, 2023
@dngray dngray added the t:correction content corrections or errors label Jul 4, 2023
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also changes in config/layout that have to be reverted. I’d have to look at the original commit to see everything that was changed, but I can check it out when I get home.

@dngray
Copy link
Member Author

dngray commented Jul 5, 2023

That's okay, I checked this with a local preview build and it did seem to look alright, but I wasn't sure.

dngray added a commit that referenced this pull request Jul 7, 2023
@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 1502f1b
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/64ace27dc73b670008fbf72d
😎 Deploy Preview https://deploy-preview-2223.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dngray
Copy link
Member Author

dngray commented Jul 7, 2023

I’d have to look at the original commit to see everything that was changed, but I can check it out when I get home.

I thought there were some permanent changes in ff60d62 which is why I didn't revert it in full.

jonaharagon pushed a commit that referenced this pull request Jul 10, 2023
jonaharagon added a commit that referenced this pull request Jul 10, 2023
Co-Authored-By: Jonah Aragon <jonah@triplebit.net>
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there were some permanent changes in ff60d62 which is why I didn't revert it in full.

There were, but there were also some changes to the social preview cards that needed to be reverted. Fixed!

@dngray dngray merged commit 1502f1b into main Jul 11, 2023
3 checks passed
@dngray dngray deleted the pr-pride-month-over branch July 11, 2023 05:03
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-13/13229/1

@dngray dngray restored the pr-pride-month-over branch July 20, 2023 08:08
dngray added a commit that referenced this pull request Jul 20, 2023
dngray added a commit that referenced this pull request Jul 20, 2023
@dngray
Copy link
Member Author

dngray commented Jul 20, 2023

This one I had to re-author in 1c1ecf7 as we forgot to remove the cover.

If we're going to regularly do this maybe we should just have a build time variable.

@jonaharagon
Copy link
Member

We didn't forget, you deleted the change when you merged this.

BECsU6LhYyGnLSfh

@jonaharagon
Copy link
Member

Also yeah, but I did this one pretty janky this year because mkdocs-material was missing a bunch of features that would've made this easier, which I requested and have been added in the latest version, so next time around we can do this cleanly.

@jonaharagon jonaharagon mentioned this pull request Jul 20, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:correction content corrections or errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants