Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NewsFlash as a recommendation under 'News Aggregators' #2360

Merged
merged 1 commit into from Jan 28, 2024
Merged

Add NewsFlash as a recommendation under 'News Aggregators' #2360

merged 1 commit into from Jan 28, 2024

Conversation

rollsicecream
Copy link
Contributor

Relevant forum post

Changes proposed in this PR:

  • Add NewsFlash as a recommendation under the 'News Aggregators' category of the website.
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@netlify Netlify
Copy link

netlify bot commented Dec 25, 2023 •
edited

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 93081f8
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65b51a4c2de938000832e2c9
😎 Deploy Preview https://deploy-preview-2360.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 72 (🔴 down 2 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/add-newsflash-for-news-aggregators/15814/1

@rollsicecream
Copy link
Contributor Author

Any updates?

jonaharagon
jonaharagon requested changes Jan 6, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leaving reminder that someone needs to add this to docs/tools.md before merging

@rollsicecream
Copy link
Contributor Author

Done! It can be merged now.

@rollsicecream
Copy link
Contributor Author

Any updates on this?

@dngray dngray mentioned this pull request Jan 27, 2024
Merged
4 tasks
@dngray dngray added the c:software self-hosted/decentralized software and related topics label Jan 27, 2024
@rollsicecream @dngray
Add NewsFlash (#2360)
93081f8 
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray
Copy link
Member

dngray commented Jan 28, 2024

This will need a PR shortly after to convert to HTML admonitions https://www.privacyguides.org/en/meta/admonitions/

@dngray dngray merged commit 93081f8 into privacyguides:main Jan 28, 2024
4 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-20/16594/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
c:software self-hosted/decentralized software and related topics
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rollsicecream @privacyguides-bot @dngray @jonaharagon