Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken blacklisting link (html admonition) #2378

Merged
merged 1 commit into from Feb 10, 2024

Conversation

dngray
Copy link
Member

@dngray dngray commented Jan 28, 2024

Changes proposed in this PR:

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Copy link

netlify bot commented Jan 28, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 7c0ff58
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65c737b1b0cda50008a60125
😎 Deploy Preview https://deploy-preview-2378.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 83 (🟢 up 8 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dngray dngray added t:correction content corrections or errors t:bug website bugs or errors labels Jan 28, 2024
@dngray dngray force-pushed the pr-html-admonitions-android branch from c939e0f to 2f4554f Compare January 28, 2024 12:54
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure I'm not missing a bug, switching to HTML admonitions in this PR isn't being done to fix anything broken right?

Signed-off-by: Jonah Aragon <jonah@triplebit.net>
@dngray dngray merged commit 7c0ff58 into main Feb 10, 2024
7 checks passed
@dngray dngray deleted the pr-html-admonitions-android branch February 10, 2024 08:49
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-20-1/16742/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:bug website bugs or errors t:correction content corrections or errors
Development

Successfully merging this pull request may close these issues.

None yet

3 participants