Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Desktop browsers page to HTML admonitions #2392

Merged
merged 1 commit into from Feb 10, 2024
Merged

Convert Desktop browsers page to HTML admonitions #2392

merged 1 commit into from Feb 10, 2024

Conversation

rollsicecream
Copy link
Contributor

Changes proposed in this PR:

  • Convert Desktop browsers page to HTML admonitions
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@netlify Netlify
Copy link

netlify bot commented Feb 4, 2024 •
edited

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit ede201f
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65c7567215310a00088c9fcf
😎 Deploy Preview https://deploy-preview-2392.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 75 (no change from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@rollsicecream rollsicecream force-pushed the html-admonitions-browsers branch 2 times, most recently from c84c522 to d585516 Compare February 4, 2024 13:24
@rollsicecream
Copy link
Contributor Author

rollsicecream commented Feb 4, 2024 •
edited

There is a problem on the preview :

Capture d’écran du 2024-02-04 15-20-32

If someone could help, this will be great 😀

@rollsicecream rollsicecream force-pushed the html-admonitions-browsers branch 5 times, most recently from 50ed38d to 820f2d6 Compare February 7, 2024 18:24
@freddy-m freddy-m added the c:browsers browsers, add-ons, and related topics label Feb 8, 2024
@dngray dngray added the t:bug website bugs or errors label Feb 10, 2024
dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Feb 10, 2024
@dngray
Convert Desktop browser HTML admonitions (privacyguides#2392)
aea9d6e 
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray
Convert Desktop browser HTML admonitions (privacyguides#2392)
ede201f 
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray
Copy link
Member

dngray commented Feb 10, 2024

If someone could help, this will be great 😀

I fixed that, i think the trick was to move it outside the div block, seems to work now.

@dngray dngray merged commit ede201f into privacyguides:main Feb 10, 2024
4 checks passed
@rollsicecream rollsicecream deleted the html-admonitions-browsers branch February 10, 2024 11:51
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-20-1/16742/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
c:browsers browsers, add-ons, and related topics t:bug website bugs or errors
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rollsicecream @dngray @privacyguides-bot @freddy-m