Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend Fedora Atomic Desktops (rebranded) #2393

Merged
merged 1 commit into from Feb 10, 2024
Merged

Recommend Fedora Atomic Desktops (rebranded) #2393

merged 1 commit into from Feb 10, 2024

Conversation

freddy-m
Copy link
Member

@freddy-m freddy-m commented Feb 6, 2024

Changes proposed in this PR:

  • what it says on the tin, really.
  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@freddy-m freddy-m added the c:os operating systems and related topics label Feb 6, 2024
@freddy-m freddy-m requested a review from dngray February 6, 2024 10:33
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2024 •
edited

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 3f26dd3
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65c7a919deede200084e31b4
😎 Deploy Preview https://deploy-preview-2393.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 81 (🟢 up 6 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

dngray
dngray requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on the blog post from fedora to go live. first.

@jonaharagon
Copy link
Member

Do we want to replace "Fedora Silverblue" with "Fedora Atomic Desktops" on the site entirely, now that they have a unified brand?

Calling them all "Fedora Silverblue" is not entirely accurate as noted at #2317 (comment) and the unified brand resolves my concern at #2317 (comment).

Unless we still want to only recommend the GNOME version first and foremost?

@dngray
Copy link
Member

dngray commented Feb 10, 2024 •
edited

Do we want to replace "Fedora Silverblue" with "Fedora Atomic Desktops" on the site entirely, now that they have a unified brand?

Yes that was the intention.

Unless we still want to only recommend the GNOME version first and foremost?**

No.

jonaharagon pushed a commit that referenced this pull request Feb 10, 2024
@freddy-m @jonaharagon
Recommend Fedora Atomic Desktops (#2393)
1b0a395 
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
@jonaharagon jonaharagon changed the title Update Silverblue link Recommend Fedora Atomic Desktops (rebranded) Feb 10, 2024
dngray pushed a commit that referenced this pull request Feb 10, 2024
@freddy-m @dngray
Recommend Fedora Atomic Desktops (#2393)
8f6bdbb 
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
dngray
dngray approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freddy-m @dngray
Recommend Fedora Atomic Desktops (#2393)
3f26dd3 
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 3f26dd3 into main Feb 10, 2024
6 of 7 checks passed
@dngray dngray deleted the pr-sliverblue branch February 10, 2024 16:49
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-20-1/16742/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
c:os operating systems and related topics
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@freddy-m @jonaharagon @dngray @privacyguides-bot