Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Email Aliasing page #2409

Merged
merged 1 commit into from Mar 16, 2024
Merged

Conversation

rollsicecream
Copy link
Contributor

@rollsicecream rollsicecream commented Feb 18, 2024

Changes proposed in this PR:

  • Add Email Aliasing page

  • Remove all E-Mail alias services from "Email Services" page and move them to that new page.

For now, this doesn't have any criteria since we are in discussion here : https://discuss.privacyguides.net/t/email-aliasing-on-separate-page/16921

When the discussion will come to an end, the necessary changes will be done to this PR. Let's say it's a "prototype".

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/email-aliasing-on-separate-page/16921/13

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 2b88698
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65f569d1650d120008f1949e
😎 Deploy Preview https://deploy-preview-2409.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 82 (🟢 up 6 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@freddy-m freddy-m added the c:providers service providers and similar centralized/federated services label Feb 19, 2024
@jonaharagon
Copy link
Member

Awesome, thanks for this. Part of this PR will have to be removing them from email.md as well.

@rollsicecream
Copy link
Contributor Author

@jonaharagon Done! As you requested.

Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rollsicecream
Copy link
Contributor Author

@jonaharagon
Copy link
Member

I think that presents too much of a risk/problem for us. Replacing with a photo by Joel Dunn at https://unsplash.com/photos/black-and-white-abstract-painting-f3Ug9b50KwI (it's metaphorical lol)

jonaharagon pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 13, 2024
jonaharagon added a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 13, 2024
Co-Authored-By: Jonah Aragon <jonah@triplebit.net>
@jonaharagon jonaharagon marked this pull request as ready for review March 13, 2024 17:26
@jonaharagon jonaharagon requested a review from dngray March 13, 2024 17:31
docs/email-aliasing.md Outdated Show resolved Hide resolved
dngray added a commit to rollsicecream/privacyguides-fork that referenced this pull request Mar 16, 2024
Co-Authored-By: Jonah Aragon <jonah@triplebit.net>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
Co-Authored-By: Jonah Aragon <jonah@triplebit.net>
Co-Authored-By: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 2b88698 into privacyguides:main Mar 16, 2024
4 checks passed
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/email-aliasing-on-separate-page/16921/25

@rollsicecream rollsicecream deleted the email-aliasing-page branch March 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:providers service providers and similar centralized/federated services
Development

Successfully merging this pull request may close these issues.

None yet

5 participants