Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Thunderbird supported chat clients #2412

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Update Thunderbird supported chat clients #2412

merged 1 commit into from
Feb 21, 2024

Conversation

mmvanheusden
Copy link
Contributor

Changes proposed in this PR:

Thunderbird stopped supporting Twitter chat a while ago.
I replaced this with Odnoklassniki, which is supported.
Source:

image

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@mmvanheusden mmvanheusden mentioned this pull request Feb 18, 2024
Closed
4 tasks
@netlify Netlify
Copy link

netlify bot commented Feb 18, 2024 •
edited

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit b0aa86f
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65d5eb62c86f200008e4433d
😎 Deploy Preview https://deploy-preview-2412.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 74 (🔴 down 12 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ph00lt0
Copy link
Contributor

ph00lt0 commented Feb 18, 2024

Might as well add matrix. Matrix is also recommended on PG

@mmvanheusden
Copy link
Contributor Author

Might as well add matrix. Matrix is also recommended on PG

Good suggestion, but isn't Matrix just IRC? Because then there would be 2 different "kinds" of IRC in the list

@ph00lt0
Copy link
Contributor

ph00lt0 commented Feb 18, 2024

No matrix and IRC are not the same

@mmvanheusden
Copy link
Contributor Author

No matrix and IRC are not the same

Changed.

@freddy-m freddy-m added the pr:missing discussion PRs which add recommendations which have not yet been discussed label Feb 19, 2024
jonaharagon
jonaharagon approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@jonaharagon jonaharagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Matrix (instead of Odnoklassniki, which I have never heard of) 👍

@jonaharagon jonaharagon added t:correction content corrections or errors and removed pr:missing discussion PRs which add recommendations which have not yet been discussed labels Feb 21, 2024
@ph00lt0
Copy link
Contributor

ph00lt0 commented Feb 21, 2024

also LGTM now

freddy-m
freddy-m approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmvanheusden @dngray
Update Thunderbird supported chat clients (#2412)
b0aa86f 
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
Signed-off-by: Freddy <freddy@privacyguides.org>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit b0aa86f into privacyguides:main Feb 21, 2024
3 of 4 checks passed
@mmvanheusden mmvanheusden deleted the thunderbird-twitter branch February 21, 2024 13:00
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-21/17131/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

@freddy-m freddy-m freddy-m approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
t:correction content corrections or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mmvanheusden @ph00lt0 @privacyguides-bot @jonaharagon @freddy-m @dngray