Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in Frontends page criteria #2418

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix typo in Frontends page criteria #2418

merged 1 commit into from
Feb 29, 2024

Conversation

rollsicecream
Copy link
Contributor

Changes proposed in this PR:

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/typo-in-front-end-recommendations/17114/2

@netlify Netlify
Copy link

netlify bot commented Feb 28, 2024 •
edited

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit 6b7f2bc
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65e056fef1e01c0009547df2
😎 Deploy Preview https://deploy-preview-2418.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 76 (no change from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

freddy-m
freddy-m approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

dngray pushed a commit to rollsicecream/privacyguides-fork that referenced this pull request Feb 29, 2024
@dngray
Fix typo in Frontends page criteria (privacyguides#2418)
8ba4cb1 
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
Signed-off-by: Freddy <freddy@privacyguides.org>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray
Fix typo in Frontends page criteria (privacyguides#2418)
6b7f2bc 
Signed-off-by: Jonah Aragon <jonah@privacyguides.org>
Signed-off-by: Freddy <freddy@privacyguides.org>
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit 6b7f2bc into privacyguides:main Feb 29, 2024
@rollsicecream rollsicecream deleted the fix-frontends-typo branch February 29, 2024 10:04
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/typo-in-front-end-recommendations/17114/3

@dngray dngray added the t:correction content corrections or errors label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaharagon jonaharagon jonaharagon approved these changes

@freddy-m freddy-m freddy-m approved these changes

@dngray dngray dngray approved these changes

Assignees
No one assigned
Labels
t:correction content corrections or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rollsicecream @privacyguides-bot @jonaharagon @freddy-m @dngray