Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave cookies settings and move social media blocking #2422

Merged
merged 1 commit into from Mar 7, 2024

Conversation

redoomed1
Copy link
Contributor

Changes proposed in this PR:

(I originally submitted a PR on Codeberg, but it has returned Internal Server Errors for the past week or so.)

  • I have disclosed any relevant conflicts of interest in my post.
  • I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project.
  • I am the sole author of this work.
  • I agree to the Community Code of Conduct.

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit dd492b2
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65e97b261cb88d000879af59
😎 Deploy Preview https://deploy-preview-2422.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
4 paths audited
Performance: 82 (🟢 up 6 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 90 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/changes-in-brave-cookie-settings-and-new-script-blocking-feature/16590/2

rollsicecream

This comment was marked as outdated.

docs/desktop-browsers.md Outdated Show resolved Hide resolved
@rollsicecream
Copy link
Contributor

It does seem to work now, is it what you wanted?

@redoomed1
Copy link
Contributor Author

is it what you wanted?

Yes.

Copy link
Contributor

@rollsicecream rollsicecream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dngray dngray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this has moved

@dngray dngray added t:correction content corrections or errors c:browsers browsers, add-ons, and related topics labels Mar 7, 2024
Signed-off-by: Daniel Gray <dngray@privacyguides.org>
@dngray dngray merged commit dd492b2 into privacyguides:main Mar 7, 2024
3 of 4 checks passed
@redoomed1 redoomed1 deleted the patch-1 branch March 16, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:browsers browsers, add-ons, and related topics t:correction content corrections or errors
Development

Successfully merging this pull request may close these issues.

None yet

4 participants