fix: Update last criterion on MFA tools page #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Your preview is ready!
|
redoomed1
changed the title
jonaharagon
approved these changes
Jun 18, 2024
|
Hm, this is an interesting point. I think that @rollsicecream was correct in #2608 (comment) that this criteria doesn't affect Ente Auth, but I can imagine that "third-party" is not very clear. The changes here sound easier to understand 👍 |
|
I agree that the "third-party" wording is not very clear: is the first party the service provider (Ente Auth, in this case) or the operating system? I like your suggested change because it simplifies the criterion by removing this question from consideration. |
freddy-m
approved these changes
Jun 23, 2024
freddy-m
added
the
c:providers
- Update links for Qubes VPN docs - Update Nitrokey internal link Signed-off-by: Jonah Aragon <jonah@privacyguides.org> Signed-off-by: Freddy <freddy@privacyguides.org> Signed-off-by: Daniel Gray <dngray@privacyguides.org>
dngray
force-pushed
the
update-mfa-criterion
branch
from
1eb410c
to
9083180
Compare
dngray
approved these changes
Jun 26, 2024
|
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Contribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.