Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS cleanup #1657

Closed
Mipronimo opened this issue Jun 3, 2019 · 0 comments · Fixed by #1665
Closed

CSS cleanup #1657

Mipronimo opened this issue Jun 3, 2019 · 0 comments · Fixed by #1665
Assignees
@Mipronimo
Labels
Generic: Code-cleanup Issues concerning refactoring and clean code Layer: UI everything concerning the web frontend

Comments

@Mipronimo
Copy link
Contributor

As mentioned in 34b97d1, we should change the way how we edit our css files.

An idea is to create a file for each region like menu, sidebar, content, etc. and put the changes where they belong to.
@Mipronimo Mipronimo added Layer: UI everything concerning the web frontend Generic: Code-cleanup Issues concerning refactoring and clean code labels Jun 3, 2019
@Mipronimo Mipronimo self-assigned this Jun 3, 2019
Mipronimo added a commit that referenced this issue Jun 6, 2019
@Mipronimo
CSS code cleanup
228bdba 
As mentioned in #1657 we want to edit the style in a better way. I
started to clean our css directory a bit:

* moved the images to img/
* added css files for regions
  * content
  * menu / navbar
  * papertoken
  * signin
  * table ui
* put changes from bootstrap.css in the correct file

closes #1657
@Mipronimo Mipronimo mentioned this issue Jun 6, 2019
Merged
cornelinux pushed a commit that referenced this issue Jun 7, 2019
@Mipronimo @cornelinux
CSS code cleanup (#1665)
059e6b3 
* CSS code cleanup

As mentioned in #1657 we want to edit the style in a better way. I
started to clean our css directory a bit:

* moved the images to img/
* added css files for regions
  * content
  * menu / navbar
  * papertoken
  * signin
  * table ui
* put changes from bootstrap.css in the correct file

closes #1657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mipronimo Mipronimo

Labels
Generic: Code-cleanup Issues concerning refactoring and clean code Layer: UI everything concerning the web frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSS code cleanup privacyidea/privacyidea
1 participant
@Mipronimo