Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last remnants of PyCrypto #1548

Merged
merged 1 commit into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@plettich
Copy link
Member

commented Apr 1, 2019

  • pi-manage now uses cryptography to create the RSA-keys for signing audit
    entries
  • remove privacyidea-decrypt-safeword.py (there is no feasible solution
    to calculate (single-)DES
  • the import of audit signing keys is now done in the audit base class
  • the PI_CHECK_OLD_SIGNATURES configuration is now read only during
    initialization of the audit class
  • remove PyCrypto from setup.py and requirements.txt
  • add some more description
Remove last remnants of PyCrypto
- `pi-manage` now uses cryptography to create the RSA-keys for signing audit
  entries
- remove `privacyidea-decrypt-safeword.py` (there is no feasible solution
  to calculate (single-)DES
- the import of audit signing keys is now done in the audit base class
- the PI_CHECK_OLD_SIGNATURES configuration is now read only during
  initialization of the audit class
- remove PyCrypto from `setup.py` and `requirements.txt`
- add some more description

@plettich plettich requested a review from privacyidea/core Apr 1, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 1, 2019

Codecov Report

Merging #1548 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   96.98%   96.98%   +<.01%     
==========================================
  Files         148      148              
  Lines       17689    17714      +25     
==========================================
+ Hits        17155    17180      +25     
  Misses        534      534
Impacted Files Coverage Δ
privacyidea/lib/auditmodules/sqlaudit.py 97.28% <100%> (-0.15%) ⬇️
privacyidea/lib/auditmodules/base.py 100% <100%> (ø) ⬆️
privacyidea/lib/token.py 96.02% <0%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981e3fc...a0e8867. Read the comment docs.

@cornelinux

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@plettich, cool! Thank you!
Would you check and close the corresponding issues?

@cornelinux cornelinux merged commit 43f54cb into master Apr 1, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.98%)
Details
codecov/project 96.98% (+<.01%) compared to 981e3fc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@cornelinux cornelinux deleted the finish_removing_pycrypto branch Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.