Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last remnants of PyCrypto #1548

Merged
merged 1 commit into from Apr 1, 2019
Merged

Conversation

plettich
Copy link
Member

@plettich plettich commented Apr 1, 2019

  • pi-manage now uses cryptography to create the RSA-keys for signing audit
    entries
  • remove privacyidea-decrypt-safeword.py (there is no feasible solution
    to calculate (single-)DES
  • the import of audit signing keys is now done in the audit base class
  • the PI_CHECK_OLD_SIGNATURES configuration is now read only during
    initialization of the audit class
  • remove PyCrypto from setup.py and requirements.txt
  • add some more description

- `pi-manage` now uses cryptography to create the RSA-keys for signing audit
  entries
- remove `privacyidea-decrypt-safeword.py` (there is no feasible solution
  to calculate (single-)DES
- the import of audit signing keys is now done in the audit base class
- the PI_CHECK_OLD_SIGNATURES configuration is now read only during
  initialization of the audit class
- remove PyCrypto from `setup.py` and `requirements.txt`
- add some more description
@plettich plettich requested a review from a team April 1, 2019 12:03
@codecov
Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #1548 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   96.98%   96.98%   +<.01%     
==========================================
  Files         148      148              
  Lines       17689    17714      +25     
==========================================
+ Hits        17155    17180      +25     
  Misses        534      534
Impacted Files Coverage Δ
privacyidea/lib/auditmodules/sqlaudit.py 97.28% <100%> (-0.15%) ⬇️
privacyidea/lib/auditmodules/base.py 100% <100%> (ø) ⬆️
privacyidea/lib/token.py 96.02% <0%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 981e3fc...a0e8867. Read the comment docs.

@cornelinux
Copy link
Member

@plettich, cool! Thank you!
Would you check and close the corresponding issues?

@cornelinux cornelinux merged commit 43f54cb into master Apr 1, 2019
@cornelinux cornelinux deleted the finish_removing_pycrypto branch April 1, 2019 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants