Fix db migration with postgres #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL (and Oracle and SQLite) use sequences for autoincrement columns. If no sequence is given, one will be created automatically which clashes with the required one in `models.py` We have to create the required sequence manually but only if the backend supports it. Actually this affects all migration scripts which create columns with an auto_increment attribute. Fixes #1676
migrations/versions/48ee74b8a7c8_.py
Outdated
| def upgrade(): | ||
| try: | ||
| create_seq('tokenowner_seq') |
There was a problem hiding this comment.
Looks good! But could you wrap this call in a try-except block? This way, if creating the sequence fails for any reason, we will at least create the tokenowner table.
Codecov Report
@@ Coverage Diff @@
## branch-3.0 #1679 +/- ##
==============================================
- Coverage 96.98% 96.93% -0.05%
==============================================
Files 148 148
Lines 17849 17738 -111
==============================================
- Hits 17310 17195 -115
- Misses 539 543 +4
Continue to review full report at Codecov.
|
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL (and Oracle and SQLite) use sequences for autoincrement columns.
If no sequence is given, one will be created automatically which clashes
with the required one in
models.pyWe have to create the required sequence manually but only if the backend
supports it.
Actually this affects all migration scripts which create columns with an
auto_increment attribute.
Fixes #1676