Add email templates for email token #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #907 +/- ##
==========================================
+ Coverage 95.38% 95.76% +0.37%
==========================================
Files 129 129
Lines 15913 17344 +1431
==========================================
+ Hits 15179 16609 +1430
- Misses 734 735 +1
Continue to review full report at Codecov.
|
Also test sending email challenge with new email scheme with email.identifier.
privacyidea/lib/tokens/emailtoken.py
Outdated
| try: | ||
| f = open(message[5:], "r") | ||
| message = f.read() | ||
| f.close() |
There was a problem hiding this comment.
Minor nitpick: I think it would be cooler to use Python with (like we already do in some other places):
with open(message[5:], "r") as f:
message = f.read()| #: lib/tokens/vascotoken.py:100 | ||
| msgid "VASCO Token: Authentication using VASCO tokens" | ||
| msgstr "" | ||
|
|
There was a problem hiding this comment.
Ah, I forgot this in my PR :-(
privacyidea/lib/tokens/emailtoken.py
Outdated
| message = f.read() | ||
| f.close() | ||
| except Exception as e: # pragma: no cover | ||
| log.warning(u"Failed to read email template: {0!r}".format(e)) |
There was a problem hiding this comment.
In case the file could not be opened, the email message will be the action value of the policy, e.g. file:/etc/privacyidea/email-template.txt -- we could instead revert to a default value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #684
99.37% <88.88%> (+0.02%)95.79% <0%> (+1.68%)Continue to review full report at Codecov.
file:/etc/privacyidea/email-template.txt-- we could instead revert to a default value?