Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing RSA blind signatures. #328

Merged
merged 1 commit into from
May 24, 2022
Merged

Implementing RSA blind signatures. #328

merged 1 commit into from
May 24, 2022

Conversation

armfazh
Copy link
Member

@armfazh armfazh commented May 17, 2022

@armfazh armfazh added the v4-rc changes for adopting privacy pass specification label May 17, 2022
@armfazh armfazh self-assigned this May 17, 2022
chris-wood
chris-wood reviewed May 18, 2022
View reviewed changes
src/blindrsa/index.test.ts Outdated Show resolved Hide resolved
src/blindrsa/index.test.ts Outdated Show resolved Hide resolved
src/blindrsa/index.ts Outdated Show resolved Hide resolved
src/blindrsa/index.ts Outdated Show resolved Hide resolved
src/blindrsa/index.ts Outdated Show resolved Hide resolved
Base automatically changed from removeTsJest to master May 19, 2022 15:12
chris-wood
chris-wood approved these changes May 20, 2022
View reviewed changes
src/blindrsa/blindrsa.test.ts Outdated Show resolved Hide resolved
lukevalenta
lukevalenta approved these changes May 23, 2022
View reviewed changes
Copy link

@lukevalenta lukevalenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but lgtm!

src/blindrsa/util.ts Show resolved Hide resolved
src/blindrsa/testdata/rsablind_vectors.json Show resolved Hide resolved
src/blindrsa/blindrsa.ts Outdated Show resolved Hide resolved
src/blindrsa/util.ts Show resolved Hide resolved
lukevalenta
lukevalenta approved these changes May 24, 2022
View reviewed changes
Copy link

@lukevalenta lukevalenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new changes look good!

@armfazh armfazh merged commit da52ce5 into master May 24, 2022
@armfazh armfazh deleted the blindRSA branch May 24, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-wood chris-wood chris-wood approved these changes

@lukevalenta lukevalenta lukevalenta approved these changes

@cdrubin cdrubin Awaiting requested review from cdrubin

@thibmeu thibmeu Awaiting requested review from thibmeu

Assignees

@armfazh armfazh

Labels
v4-rc changes for adopting privacy pass specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@armfazh @chris-wood @lukevalenta