Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cloudflare tokens issuance domain #397

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix Cloudflare tokens issuance domain #397

merged 1 commit into from
Aug 4, 2023

Conversation

thibmeu
Copy link
Contributor

@thibmeu thibmeu commented Aug 4, 2023

Move from captcha.website to issuance.privacypass.cloudflare.com. This makes Cloudflare more identifiable as an issuer for Cloudflare tokens.

@thibmeu thibmeu force-pushed the thibmeu/fix-cloudflare-issuance-domains branch from 4f410ed to 9ec2a51 Compare August 4, 2023 12:28
Lekensteyn
Lekensteyn reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@Lekensteyn Lekensteyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests still list the old domain, should those also be updated?

Lekensteyn
Lekensteyn reviewed Aug 4, 2023
View reviewed changes
src/background/index.ts Outdated Show resolved Hide resolved
@Lekensteyn Lekensteyn force-pushed the thibmeu/fix-cloudflare-issuance-domains branch 2 times, most recently from 9dd3aeb to c68c4d4 Compare August 4, 2023 12:44
@thibmeu @Lekensteyn
Fix Cloudflare tokens issuance domain
67f3291 
Move from captcha.website to issuance.privacypass.cloudflare.com.
This makes Cloudflare more identifiable as an issuer for Cloudflare
tokens.
@Lekensteyn Lekensteyn force-pushed the thibmeu/fix-cloudflare-issuance-domains branch from c68c4d4 to 67f3291 Compare August 4, 2023 13:00
Lekensteyn
Lekensteyn approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@Lekensteyn Lekensteyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally on Firefox 115.0.3 in a new browsing profile.

@thibmeu thibmeu merged commit 53f98a0 into privacypass:master Aug 4, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lekensteyn Lekensteyn Lekensteyn approved these changes

@migueldemoura migueldemoura migueldemoura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thibmeu @Lekensteyn @migueldemoura