Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move android::java_io to java::io #705

Merged
merged 4 commits into from
Sep 3, 2014
Merged

Move android::java_io to java::io #705

merged 4 commits into from
Sep 3, 2014

Conversation

xymus
Copy link
Contributor

@xymus xymus commented Sep 1, 2014

Fix #696

@privat
Copy link
Member

privat commented Sep 1, 2014

Le test de licence pete cat il s'attendait a un 'This file...', avec un T majuscule.

#
# this module is used by `assets_and_resources` and `audio` for advanced purposes
module java_io
# This module is used by `android::assets_and_resources` and `android::audio`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P'te mettre a jour le description du module ?

@privat
Copy link
Member

privat commented Sep 2, 2014

+1 mais, faudrait Supprimer le java_io de tests/cc.skip

@Morriar
Copy link
Member

Morriar commented Sep 2, 2014

+1

Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
Signed-off-by: Alexis Laferrière <alexis.laf@xymus.net>
@privat privat merged commit 65a8850 into nitlang:master Sep 3, 2014
privat added a commit that referenced this pull request Sep 3, 2014
Fix #696

Pull-Request: #705
Reviewed-by: Jean Privat <jean@pryen.org>
Reviewed-by: Alexandre Terrasa <alexandre@moz-code.org>
@xymus xymus deleted the java_io branch September 9, 2014 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

android/java_io.nit: can't compile separately
3 participants