Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SecureMul from trait bounds #1022

Open
danielmasny opened this issue Apr 25, 2024 · 1 comment
Open

Remove SecureMul from trait bounds #1022

danielmasny opened this issue Apr 25, 2024 · 1 comment

Comments

@danielmasny
Copy link
Collaborator

#1021 does not implement SecureMul for any context anymore.

Therefore SecureMul had to be in the trait bounds of several functions.

Task: Remove the trait bound.

Add the trait bound C:Upgradable. Implement SecureMul for all Boolean types for ::DZKPUpgraded. Further, implement SecureMul for all primefield types for ::Upgraded. This would require to change all functions to use the new maliciousAPI and upgrade the context whenever multiplications are used. This should allow to remove SecureMul from the trait bounds.

@danielmasny
Copy link
Collaborator Author

@andyleiserson pointed out that this will not work. Even if we implement SecureMul for Semi Honest DZKPUpgraded and Malicious DZKPUpgraded, which are all structs that implement the DZKPUpgraded trait, the compiler will not know that structs that implement the DZKPUpgraded trait will also have the SecureMul trait.

This could potentially be resolved by a new trait that bundles the SecureMul trait and DZKPUpgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant