Mod conversion [Part 1] #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoshelev
reviewed
Oct 12, 2022
src/protocol/mod.rs
Outdated
| fn fmt(&self, f: &mut Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| ModulusConversionStep::Share0XORShare1 => write!(f, "Share 0 XOR Share 1"), | ||
| ModulusConversionStep::ResultXORShare2 => write!(f, "Result XOR Share 2"), |
There was a problem hiding this comment.
Suggested change
| ModulusConversionStep::ResultXORShare2 => write!(f, "Result XOR Share 2"), | |
| ModulusConversionStep::ResultXORShare2 => write!(f, "Share 0 XOR Share 1 XOR Share 2"), |
Comment on lines
134
to
135
| let world: TestWorld<ModulusConversionTestStep> = make_world(QueryId); | ||
| let context = make_contexts(&world); |
There was a problem hiding this comment.
I think this what causes this test to run for 5 secs on my M1. You could move this initialization outside of the main loop and that would significantly speed up the runtime without sacrificing correctness
Comment on lines
146
to
148
| let b0 = rng.gen::<u8>() >= 128; | ||
| let b1 = rng.gen::<u8>() >= 128; | ||
| let b2 = rng.gen::<u8>() >= 128; |
There was a problem hiding this comment.
Suggested change
| let b0 = rng.gen::<u8>() >= 128; | |
| let b1 = rng.gen::<u8>() >= 128; | |
| let b2 = rng.gen::<u8>() >= 128; | |
| let b0 = rng.gen::<bool>(); | |
| let b1 = rng.gen::<bool>(); | |
| let b2 = rng.gen::<bool>(); |
There was a problem hiding this comment.
ah... that's much better =)
| let gen_random2 = GenRandom::new(ReplicatedBinary::new(b2, b0)); | ||
|
|
||
| let h0_future = gen_random0.execute(&context[0], record_id, step1, step2); | ||
| let h1_future = gen_random1.execute::<Fp31, TestMesh<ModulusConversionTestStep>, TestHelperGateway<ModulusConversionTestStep>, ModulusConversionTestStep>(&context[1], record_id, step1, step2); |
There was a problem hiding this comment.
Suggested change
| let h1_future = gen_random1.execute::<Fp31, TestMesh<ModulusConversionTestStep>, TestHelperGateway<ModulusConversionTestStep>, ModulusConversionTestStep>(&context[1], record_id, step1, step2); | |
| let h1_future = gen_random1.execute(&context[1], record_id, step1, step2); |
I think the only parameter that is ambiguous is the field type, so if we explicitly set it on the line 161, we don't need to specify all the types here
| let h2_future = gen_random2.execute(&context[2], record_id, step1, step2); | ||
|
|
||
| let f = try_join!(h0_future, h1_future, h2_future).unwrap(); | ||
| let output_share = validate_and_reconstruct(f); |
There was a problem hiding this comment.
Suggested change
| let output_share = validate_and_reconstruct(f); | |
| let output_share: Fp31 = validate_and_reconstruct(f); |
| let gen_random2 = GenRandom::new(ReplicatedBinary::new(b2, b0)); | ||
|
|
||
| let h0_future = gen_random0.execute(&context[0], record_id, step1, step2); | ||
| let h1_future = gen_random1.execute::<Fp31, TestMesh<ModulusConversionTestStep>, TestHelperGateway<ModulusConversionTestStep>, ModulusConversionTestStep>(&context[1], record_id, step1, step2); |
There was a problem hiding this comment.
let h1_future = gen_random1.execute(&context[1], record_id, step1, step2);
benjaminsavage
force-pushed
the
mod_conversion
branch
from
d7aa684
to
7fc29c1
Compare
benjaminsavage
force-pushed
the
mod_conversion
branch
from
7fc29c1
to
8a1d162
Compare
akoshelev
approved these changes
Oct 13, 2022
akoshelev
added a commit
to akoshelev/raw-ipa
that referenced
this pull request
Oct 16, 2022
Given the conversation in private-attribution#110 [comment](https://github.com/martinthomson/raw-ipa/pull/110/files#r992706026) we don't seem to need to dynamically change the identities of helpers dynamically. Therefore we don't need to force client code to obtain a reference to the channel first. The standard way to access helper identity should be via `ProtocolContext` and, in some cases, via `Gateway`
akoshelev
added a commit
to akoshelev/raw-ipa
that referenced
this pull request
Oct 16, 2022
Given the conversation in private-attribution#110 [comment](https://github.com/martinthomson/raw-ipa/pull/110/files#r992706026) we don't seem to need to dynamically change the identities of helpers dynamically. Therefore we don't need to force client code to obtain a reference to the channel first. The standard way to access helper identity should be via `ProtocolContext` and, in some cases, via `Gateway`
This was referenced Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To convert from XOR secret shares of match keys, the lists of replicated secret sharings of each bit in Z_p, we will need to generate pairs of secret sharings of "r", a random number not known to any of the helpers.
This diff introduces code that given a binary replicated secret sharing of "r" (which can be locally generated using PRSS), converts that into a replicated secret sharing of the same value in Z_p. This is the main work involved in the modulus conversion.
There are additional optimisations to add later.