Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom thread creation #1636

Merged
merged 8 commits into from
Feb 19, 2024
Merged

Add custom thread creation #1636

merged 8 commits into from
Feb 19, 2024

Conversation

huitema
Copy link
Collaborator

@huitema huitema commented Feb 18, 2024

This PR adds two important features to the network thread support:

  1. Support of thread creation in application frameworks that require framework specific APIs instead of using the platform APIs in Windows or the pthread APIs in Unix systems.

  2. Support of thread naming, which is difficult to implement in some OSes for which the naming API must be used from inside the named thread (Apple, mostly).

See the definition of picoquic_start_custom_network_thread in the new picoquic_packet_loop.h.

@huitema
Copy link
Collaborator Author

huitema commented Feb 19, 2024

The appveyor tests are failing with a diagnostic "Failed to set up the execution context to run the test". On line search points to something related to dll dependencies. The Visual Studio tests are passing locally, so we get unblocked by just disabling test execution in Appveyor, while still checking that compile succeeds.

@huitema huitema merged commit 21834fc into master Feb 19, 2024
11 checks passed
@huitema huitema deleted the custom_thread branch February 19, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant