Rework scheduling in socket loop #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhasHere
reviewed
Jun 2, 2024
|
@suhasHere I rewrote the comments in the code for clarity. |
suhasHere
approved these changes
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1697 describes a failure mode of real time communication, with series of apparently "suspended" intervals. These effects may have multiple cause. One of these events happens when both ends are attempting to send high definition video. It seems that the code can become locked into either sending a large number of packets without spending time receiving, or receiving a large number of packets without spending time sending. This PR adds limits to how many packets can be received without sending something, or sent without attempting to receive the latest packet.
The PR also includes updates to the "mediatest" test code, to better simulate the effects of Wi-Fi suspension. That code was instrumental in pointing out that something else than WI-Fi might be creating the problem.