Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/browser example #68

Merged
merged 6 commits into from
Jun 5, 2021
Merged

Feature/browser example #68

merged 6 commits into from
Jun 5, 2021

Conversation

privateOmega
Copy link
Owner

@privateOmega privateOmega commented May 1, 2021

Switch from CJS to UMD build for browser support as well along with support for node.js
Switched out Crypto with ShortID
Replaced html-minifier package with custom regex solution.

fix #3

@amarksnightwatch
Copy link

I'm also interested in using in browser. Are you releasing a new npm version soon?

@amrita-syn
Copy link
Collaborator

We need a browser a example. Rudimentary beginning attached. I couldn't get the file to get attached to window... may be you know how?

browser-example.zip

@privateOmega
Copy link
Owner Author

@amrita-syn my bad, I never tried the umd build via script tag on browser, but on React. I will try this out ASAP.

@wnabil
Copy link

wnabil commented May 29, 2021

@privateOmega any news when this will be released ?

@amilich
Copy link

amilich commented May 30, 2021

Any plans to release soon?

@privateOmega
Copy link
Owner Author

privateOmega commented Jun 3, 2021

@amrita-syn could you please test this with react and if all looks good, lets approve and merge it, since there's like so much demand. I am unable to get it working with browser's umd build due to lack of js module system knowledge. I will add a disclaimer in the README, saying it won't work with browser rightaway if there's no bundler present to resolve dependencies.

@wnabil @amilich soon I hope

@amrita-syn
Copy link
Collaborator

amrita-syn commented Jun 4, 2021 via email

Copy link
Collaborator

@amrita-syn amrita-syn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@privateOmega privateOmega merged commit 078fa5d into develop Jun 5, 2021
@privateOmega
Copy link
Owner Author

Released a new version which contains this PR. So finally we have browser support :D

@privateOmega privateOmega deleted the feature/browser-example branch June 5, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants