-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/browser example #68
Conversation
I'm also interested in using in browser. Are you releasing a new npm version soon? |
We need a browser a example. Rudimentary beginning attached. I couldn't get the file to get attached to |
@amrita-syn my bad, I never tried the umd build via script tag on browser, but on React. I will try this out ASAP. |
@privateOmega any news when this will be released ? |
Any plans to release soon? |
@amrita-syn could you please test this with react and if all looks good, lets approve and merge it, since there's like so much demand. I am unable to get it working with browser's umd build due to lack of js module system knowledge. I will add a disclaimer in the README, saying it won't work with browser rightaway if there's no bundler present to resolve dependencies. |
Sure, we can pick that piece up later.
Regards,
Amrita
…On Fri, 4 Jun 2021 at 01:07, Kiran Mathew Mohan ***@***.***> wrote:
@amrita-syn <https://github.com/amrita-syn> could you please test this
with react and if all looks good, lets approve and merge it, since there's
like so much demand. I am unable to get it working with browser's umd build
due to lack of js module system knowledge. I will add a disclaimer in the
README, saying it won't work with browser rightaway if there's no bundler
present to resolve dependencies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK3FYD27TG4HXPFWTQKDQXTTQ7KWHANCNFSM436P67KQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine.
Released a new version which contains this PR. So finally we have browser support :D |
Switch from CJS to UMD build for browser support as well along with support for node.js
Switched out Crypto with ShortID
Replaced html-minifier package with custom regex solution.
fix #3