Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

traffic limiter related unit tests fail in HHVM #21

Closed
elrido opened this issue Jul 9, 2016 · 1 comment
Closed

traffic limiter related unit tests fail in HHVM #21

elrido opened this issue Jul 9, 2016 · 1 comment
Labels
bug help wanted

Comments

@elrido
Copy link
Contributor

elrido commented Jul 9, 2016

The unit tests related to traffic limiting (trafficlimiterTest::testTrafficGetsLimited() & zerobinTest::testCreateInvalidTimelimit()) fail when tested under HHVM. Since these tests use sleep calls this might be related to #4744 in HHVM.

Disabling hhvm.xenon.period did not resolve the problem, so I have disabled the HHVM testing in travis for now. If anybody has some HHVM experience, please take a look on this and let us know if this is a problem outside of the unit test or how we could improve the tests.
@elrido elrido added the bug label Jul 9, 2016
@elrido elrido mentioned this issue Jul 9, 2016
Closed
@HLeithner
Copy link
Contributor

I think you can close this, hhvm no longer support php only hack

@rugk rugk closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elrido @HLeithner @rugk