Webpack v4 API inconsistencies

[issacgerges]

Bug description

There are some issues with this package that can cause problems when used with webpack@4

• The explicit dependency on webpack-sources will bring in an additional version on most versions of webpack. These sources are passed back into the webpack compilation
  • In webpack v5, these source classes are available via the compiler (example)
  • In webpack v4, I believe an explicit dependency is needed on webpack-sources@1.4.3 to match the version used by webpck/webpack
• sourceAndMap is not consistently present on compilation sources in v4. This code should use sourceAndMap when available and fallback to a null map and source.source() (example)

Reproduction

n/a

Node.js package manager

npm

Environment

npmPackages:
  webpack: 4.x

Can you contribute a fix?

• I’m interested in opening a pull request for this issue.

[privatenumber]

I really appreciate this issue. Thanks for the feedback @issacgerges.

RE: First bullet
I think you're definitely right. Will fix.

RE: Second bullet
Do you have an example where sourceAndMap will not be present in Webpack 4? So far, it hasn't been a problem for me, and I feel like I'd be getting bug reports if it wasn't available. In any case, if it's possible, I'd like to cover it in a test.

[issacgerges]

No worries! I know one example is that plugins can (and sometimes do) manually add assets to the compilation, here's one such example, those usually only satisfy source and size. I'm actually no longer confident you can even rely on this in webpack@5. Even webpack does similar checks internally

[privatenumber]

Thanks @issacgerges !
Should be covered now.

[privatenumber]

🎉 This issue has been resolved in version 2.21.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀