Module resolution problems

[thorn0]

Problem

This package doesn't play well with TypeScript when moduleResolution is set to NodeNext.

See https://arethetypeswrong.github.io/?p=esbuild-loader%404.0.2 for a detailed explanation of the problem.

Possible solutions:

1. remove "type": "module" from package.json
2. or rename dist/index.d.ts -> dist/index.d.cts

Expected behavior

I expected this line

import { EsbuildPlugin } from "esbuild-loader";

to keep working after I changed the moduleResolution option in tsconfig.json from Node to NodeNext.

For now we use a dynamic import as a workaround.

Minimal reproduction URL

https://stackblitz.com/edit/node-1zhtpc?file=foo.ts&view=editor

Version

4.0.2

Node.js version

16+

Package manager

npm

Operating system

Windows

Contributions

• I plan to open a pull request for this issue
• I plan to make a financial contribution to this project

[privatenumber]

I see why it's technically not correct, but I'd like to make sure I'm seeing the same problem first.

In your reproduction, I'm still able to get the correct types when I add:

import { EsbuildPlugin } from "esbuild-loader";

[thorn0]

Try this in a .ts CommonJS module, not in .js. That's why there is the foo.ts file in my reproduce.

[privatenumber]

Whys it imported from a .ts file? It's designed to be imported from a Webpack config file

FYI Setting "allowJs": true works too

[thorn0]

webpack is a library. CLI is not the only way to use it.

[privatenumber]

Could've just said "I'm using Webpack via Node rather than the CLI" instead of the snarky response.

Feel free to submit a PR.

[privatenumber]

🎉 This issue has been resolved in version 4.0.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀