Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: esbuild as a peer dependency #35

Merged
merged 6 commits into from Sep 27, 2020
Merged

Conversation

privatenumber
Copy link
Owner

@privatenumber privatenumber commented Aug 23, 2020

This allows users to upgrade esbuild independently of esbuild-loader.

This is great because esbuild has a new release every other day.

Unfortunately, this is going to be a breaking change.

Hope to queue this with some other BCs.

Closes #25

@airhorns
Copy link
Contributor

This makes a lot of sense to me, would love to get this in so esbuild can be upgraded independently!

@airhorns
Copy link
Contributor

Oh, I think this commit is actually on master already and this PR can be closed. Would be dandy to get a release with it out!

@privatenumber
Copy link
Owner Author

Still holding this because I want to batch it with another breaking change, and also waiting for esbuild v1 because I imagine there's going to be a breaking change there.

Do you want me to do a dependency upgrade release instead?

Alternatively, if you're using yarn, you can use the resolutions feature.

@airhorns
Copy link
Contributor

Oh sorry I was looking at the wrong branch on the root page 😅

No rush, I am just using resolutions :)

@privatenumber privatenumber changed the base branch from develop to next September 23, 2020 06:10
@privatenumber privatenumber merged commit 091d9ba into next Sep 27, 2020
@privatenumber privatenumber deleted the esbuild-peer-dependency branch September 27, 2020 01:17
@github-actions
Copy link

🎉 This PR is included in version 2.4.1-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

privatenumber added a commit that referenced this pull request Sep 27, 2020
privatenumber added a commit that referenced this pull request Sep 27, 2020
BREAKING CHANGE: esbuild as a peer dependency
@privatenumber
Copy link
Owner Author

Adding a note that this might not be a good idea to release till esbuild is v1 (stable) because they can still technically do breaking changes (they did a breaking change on the Node API recently).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Externalizing esbuild as a peer dependency
2 participants