Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client version has been deprecated #7

Closed
greenkiwi opened this issue Jan 6, 2021 · 3 comments · Fixed by #8
Closed

Client version has been deprecated #7

greenkiwi opened this issue Jan 6, 2021 · 3 comments · Fixed by #8

Comments

@greenkiwi
Copy link
Contributor

greenkiwi commented Jan 6, 2021

We have been using this module for a while. Today we started to get this error whenever we tried to login.

Error: Device couldn't be registered.

We confirmed that our key + username + password all work when signing in via a web browser to 1Password.

Do you know if anything has changed?

It would appear that the endpoint that the client library is using for login is now deprecated.

Request:
  endpoint: v2/auth/turo-prod-op-service@turo.com/A3/HRQNKK/d702e31a83e222e67dfaa1759a


        const endpoint = `v2/auth/${email}/${key.format}/${key.id}/${this.device.uuid}`;
        const response = (await this.requestService.request(endpoint, "GET"));

Response:
{
  "reason": "deprecated"
}
@greenkiwi greenkiwi changed the title login failing Client version has been deprecated Jan 7, 2021
greenkiwi added a commit to turo/onepassword-web-client that referenced this issue Jan 7, 2021
The 1Password client version 637 has been deprecated.  This updates the
client version in the library to 945 so that it will continue to work.

fixes: [issue 7](privicy#7)
@greenkiwi
Copy link
Contributor Author

@stevenroussey-privicy This should be fixed with #8

@greenkiwi
Copy link
Contributor Author

@stevenroussey-privicy Would it make sense to have an argument passed in that would override this value? That would make it updateable without needing a new build?

@stevenroussey-privicy
Copy link
Collaborator

That would work too, but often the code needs to change as well. I'm back, so should be more up to date in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants