Addressed issue #87

[vladfulgeanu]

• solution for issue Title of Privly Applications Confuses local and remote contexts. #87
• History button changes

[smcgregor]

grep for the home_domain class and update it as appropriate. You can changing the way it was being used.

[vladfulgeanu]

Is there something else I should change?

[smcgregor]

I don't think you are getting the expectation quite right on changing the banner. Perhaps it would be better to add a page to the "Help" application that explains what the user's content server is and what scripting environment they are currently viewing. This approach could allow us to build a trusted knowledge base inside the extension.

[smcgregor]

You could then link the banner to the help page, which would further have details on how to view the pages defined by the content server instead of the extension.

[smcgregor]

Is there a reason you are using the same javascript as the Help/new.html page? I would probably use a different script. Maybe named content_server.js

[vladfulgeanu]

The only reason is not doubling most of the code, those three lines are the only addition to new.js.

[smcgregor]

This no longer needs the home_domain class and the target should no longer be specified.

[vladfulgeanu]

Why? The banner should still indicate the current content server, which is done by targeting $(.home_domain), and it should also open in a new tab.

[smcgregor]

ah, ok. I thought you removed the home_domain logic.

I still think you should open in the same tab though since that is how people expect it to behave and the app is opening in the same context.

[smcgregor]

OK, then rename the script to something that indicates it could be used in more than one page. When it is named the same thing as an HTML file, it is implicit that the HTML file owns the JS so you don't need to worry about breaking dependencies. When you change the file name to something not clearly related to a specific file, it won't cause confusion later.