Support for older node versions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjreinhart
commented
May 28, 2023
| @@ -1,3 +1,5 @@ | |||
| import {getRandomBytes} from 'shamir-secret-sharing/csprng'; | |||
There was a problem hiding this comment.
Given the contents of package.json, this import should be handled differently in different environments. Node should know to use the csprng.node.js file while bundling for the browser should use csprng.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is one piece of this library that doesn't play nice with older versions of node (< 19). That piece is the call to get random bytes, which is currently implemented using WebCrypto's
crypto.getRandomValues.cryptois not available in the global scope in older node versions and thus will break.This PR:
getRandomBytesbut with different implementations (one for the browser, one for node)csprngpackage subpath, we mean for it to use the node one. Similarly, bundlers should know to use the browser one when bundling for the browser.