Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching Google API Data #3

Merged
merged 17 commits into from Nov 4, 2022
Merged

Fetching Google API Data #3

merged 17 commits into from Nov 4, 2022

Conversation

priyaraj7
Copy link
Owner

Hi Chris,

I have fetched Google API data from backend and passed the data to frontend. Next I am going to work on itemModel.js file to create an endpoint to get all item in one API call and also planning to work on React Router.

It looks like this PR has merge conflict, I am going to work it later

Could you please review client/src/component/customer/ReviewPage.js and server/api/googleApi.js files.

Contact page and header page is just a placeholder.

Thank you

@priyaraj7 priyaraj7 changed the title Fetching Google API Fetching Google API Data Nov 3, 2022
Copy link
Collaborator

@chrisjaure chrisjaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some minor suggestions.

client/src/component/customer/ReviewPage.js Outdated Show resolved Hide resolved
client/src/component/customer/ReviewPage.js Outdated Show resolved Hide resolved
let [apiData, setApiData] = useState(null);

const getApiData = async () => {
setApiData(await getReviews());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will you handle API errors here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do in next PR. Thank you for pointing out.

priyaraj7 and others added 3 commits November 4, 2022 10:05
Co-authored-by: Chris Jaure <chrisjaure@gmail.com>
Co-authored-by: Chris Jaure <chrisjaure@gmail.com>
@priyaraj7 priyaraj7 merged commit 5d84e64 into main Nov 4, 2022
@priyaraj7 priyaraj7 deleted the review-api branch November 4, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants