Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor mesh & MCA data parsing code #73

Open
prjemian opened this issue Jan 22, 2017 · 3 comments
Open

refactor mesh & MCA data parsing code #73

prjemian opened this issue Jan 22, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@prjemian
Copy link
Owner

prjemian commented Jan 22, 2017

per #72, the code that converts the raw SPEC data into a 2-D grid resides in writer.Writer.mesh()

this code will be used in more than one place now (writer, specplot) so move it into an independent location

same for writer.Writer.mca_spectra()


from #151 : as noted in the source code:

def mesh(self, nxdata, scan):
"""*internal*: data parser for 2-D mesh and hklmesh"""
# TODO: refactor to use NeXus data model: signal, axes, data

added:
resolve TODO items in these files:

docs/source/nexus_layout/mca.rst:TODO: write
docs/source/nexus_layout/mca.rst:TODO: show with one MCA
docs/source/nexus_layout/mca.rst:TODO: show with CALIB
@prjemian prjemian added this to the 2017.0201.0 release milestone Jan 22, 2017
@prjemian prjemian self-assigned this Jan 22, 2017
@prjemian prjemian added the task label Jan 22, 2017
@prjemian prjemian changed the title refactor mesh data pasring code refactor mesh data parsing code Jan 22, 2017
@prjemian prjemian changed the title refactor mesh data parsing code refactor mesh & MCA data parsing code Jan 22, 2017
@prjemian
Copy link
Owner Author

CAUTION: Do this in steps, with unit testing on the spec2nexus.writer.Writer() code to ensure no consequences on the user community

@prjemian
Copy link
Owner Author

This work was undone in commit 2c9b541.
Can we bring those changes back?

@prjemian prjemian reopened this Mar 19, 2017
@prjemian prjemian modified the milestones: 2017.4 release, 2017.0201 release Mar 19, 2017
@prjemian prjemian modified the milestones: 2017.5 release, later May 22, 2017
@prjemian prjemian added this to TO DO in Priorities Aug 1, 2017
@prjemian prjemian modified the milestones: 2020.0.0, 2020.1.0 May 16, 2019
@prjemian prjemian modified the milestones: 2021.1.0, later milestone Jul 15, 2019
@prjemian prjemian removed this from the later milestone milestone Aug 14, 2019
@prjemian prjemian modified the milestones: 2021.1.3, 2021.1.4 Aug 15, 2019
@prjemian prjemian modified the milestones: 2021.1.4, 2021.1.5 Oct 18, 2019
@prjemian prjemian modified the milestones: 2021.1.5, 2021.1.6, 2021.1.7 Nov 1, 2019
@prjemian prjemian modified the milestones: 2021.1.7, 2021.1.8 Nov 21, 2019
@prjemian prjemian modified the milestones: 2021.1.8, 2021.2.0 Nov 10, 2020
@prjemian prjemian removed this from TO DO in Priorities Nov 6, 2021
@prjemian prjemian removed this from Needs triage in 2021.2.0 maintenance release project Nov 6, 2021
@prjemian prjemian modified the milestones: 2021.12.0, later milestone Nov 6, 2021
@prjemian prjemian added this to To do in 2021.2.1 release Mar 18, 2022
@prjemian prjemian modified the milestones: later milestone, 2021.2.1 Mar 18, 2022
@prjemian prjemian removed this from To do in 2021.2.1 release May 24, 2022
@prjemian prjemian modified the milestones: 2021.2.1, 2021.2.2 May 24, 2022
@prjemian
Copy link
Owner Author

prjemian commented Sep 5, 2022

This is a refactoring of the code that potentially breaks the existing API (by changing the imports). Move to milestone for next major version number.

@prjemian prjemian modified the milestones: 2021.2.2, 2022.0.0 Sep 5, 2022
@prjemian prjemian modified the milestones: 2022.0.0, 2022.0.1 Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant