New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address changes to Schema().load and Schema().dump in marshmallow v3 #109

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
1 participant
@prkumar
Owner

prkumar commented Sep 21, 2018

After marshmallow 3.0, Schema().load and Schema().dump don't return a (data, errors) tuple any more. Only data is returned.

See: https://marshmallow.readthedocs.io/en/3.0/upgrading.html

This tiny PR accommodates these changes for our examples and integrations with marshmallow.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 21, 2018

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     25           
  Lines        1392   1395    +3     
  Branches      131    131           
=====================================
+ Hits         1392   1395    +3
Impacted Files Coverage Δ
uplink/converters/marshmallow_.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2078520...b0bfe26. Read the comment docs.

codecov bot commented Sep 21, 2018

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     25           
  Lines        1392   1395    +3     
  Branches      131    131           
=====================================
+ Hits         1392   1395    +3
Impacted Files Coverage Δ
uplink/converters/marshmallow_.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2078520...b0bfe26. Read the comment docs.

@prkumar prkumar added this to the v0.7.0 milestone Sep 21, 2018

@prkumar prkumar merged commit 151f1e1 into master Sep 21, 2018

5 checks passed

codeclimate All good!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 2078520
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@prkumar prkumar deleted the feature/v0.7.0/marshmallow-v3 branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment