-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Consumer.exceptions
property for handling client exceptions
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 1395 1410 +15
Branches 131 131
=====================================
+ Hits 1395 1410 +15
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57.
Each
Consumer
instance has anexceptions
property that exposes an enum of standard HTTP client exceptions that can be handled:This approach to handling exceptions decouples your code from the backing HTTP client, improving code reuse and testability.
Here are the HTTP client exceptions that are exposed through this property:
BaseClientException
: Base exception for client connection errors.ConnectionError
: A client socket error occurred.ConnectionTimeout
: The request timed out while trying to connect to the remote server.ServerTimeout
: The server did not send any data in the allotted amount of time.SSLError
: An SSL error occurred.InvalidURL
: URL used for fetching is malformed.Of course, you can also explicitly catch a particular client error from the backing client (e.g.,
requests.FileModeWarning
). This may be useful for handling exceptions that are not exposed through theConsumer.exceptions
property, for example:FYI: @daa