Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users specify if/how None values are encoded #126

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

nphilipp
Copy link
Contributor

@nphilipp nphilipp commented Dec 6, 2018

Fixes #125.

Changes proposed in this pull request:

  • Adds an encode_none parameter to Query which lets users specify if at all, and if yes how a value of None should be sent to the service.

This changes behavior slightly: if a parameter is None (per its default value or because the user set it), previously it was encoded as ...?name=None. To retain this behavior, a user would have to specify Query(..., encode_none="None").

Attention: @prkumar

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #126   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          25     25           
  Lines        1419   1425    +6     
  Branches      134    136    +2     
=====================================
+ Hits         1419   1425    +6
Impacted Files Coverage Δ
uplink/arguments.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a11c59...249c56f. Read the comment docs.

@prkumar
Copy link
Owner

prkumar commented Dec 6, 2018

Looks good! Also, thanks for including documentation with your changes🥇

@prkumar prkumar added this to the v0.7.0 milestone Dec 6, 2018
@prkumar prkumar merged commit 8b58b8a into prkumar:master Dec 6, 2018
@prkumar prkumar mentioned this pull request Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants