Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/session mem leak #134

Merged
merged 5 commits into from
Jan 4, 2019
Merged

Conversation

SakornW
Copy link
Contributor

@SakornW SakornW commented Jan 2, 2019

Fixes #130

Changes proposed in this pull request:

  • ensure close session in del instead of atexit

Attention: @prkumar

SakornW and others added 2 commits December 26, 2018 13:39
Use __del__ to cleanup session instead of atexit. atexit function will automatically executed upon normal interpreter termination. But in the context of wsgi application, this never been called unless we stop application. While as for __del__, it will be called as part of gc.
@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #134 into master will decrease coverage by 0.05%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage     100%   99.94%   -0.06%     
==========================================
  Files          38       38              
  Lines        1867     1873       +6     
  Branches      158      158              
==========================================
+ Hits         1867     1872       +5     
- Misses          0        1       +1
Impacted Files Coverage Δ
uplink/clients/aiohttp_.py 100% <100%> (ø) ⬆️
uplink/clients/requests_.py 97.72% <80%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782f07d...e016e37. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 2, 2019

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #134   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          38     38           
  Lines        1867   1888   +21     
  Branches      158    160    +2     
=====================================
+ Hits         1867   1888   +21
Impacted Files Coverage Δ
uplink/clients/requests_.py 100% <100%> (ø) ⬆️
uplink/clients/aiohttp_.py 100% <100%> (ø) ⬆️
uplink/arguments.py 100% <0%> (ø) ⬆️
uplink/converters/keys.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782f07d...1c3067a. Read the comment docs.

@prkumar prkumar added this to the v0.8.0 milestone Jan 4, 2019
@prkumar prkumar merged commit 7bd0978 into prkumar:master Jan 4, 2019
@prkumar
Copy link
Owner

prkumar commented Jan 9, 2019

@SakornW - Just to follow up: if you'd like your name to appear in the AUTHORS.rst file, please let me know what name and/or public handle (e.g., @SakornW) that you'd like me to append to the file. For example, here's my entry in AUTHORS.rst:

Raj Kumar (@prkumar)

Alternatively, you could open a separate PR with that change. Whatever works best for you! Thanks for contributing 😃

@SakornW
Copy link
Contributor Author

SakornW commented Jan 11, 2019

@prkumar Thanks, that would be nice :).
Please help append as 'Sakorn Waungwiwatsin @SakornW'

@prkumar
Copy link
Owner

prkumar commented Jan 11, 2019

@SakornW - Added! 😄

@prkumar prkumar mentioned this pull request Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in consumer class
2 participants