Stop sharing class decorators across siblings #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that, when writing a superclass that is extended by two separate subclasses, class-level decorators are shared across the siblings. You can reproduce this issue with the following example:
Running the above code snippet, you'll notice that the first invocation will throw an
AttributeError
since the response is wrapped by bothlambda _: 2
andlambda x: x.json()
; notably, the latter handler receives andint
(i.e.,2
) as it's input, which doesn't have ajson
method.