Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit Header with None value from request #169

Merged
merged 1 commit into from
Aug 10, 2019
Merged

Omit Header with None value from request #169

merged 1 commit into from
Aug 10, 2019

Conversation

prkumar
Copy link
Owner

@prkumar prkumar commented Aug 10, 2019

Fixes #167.

@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #169   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          41     41           
  Lines        2170   2173    +3     
  Branches      173    173           
=====================================
+ Hits         2170   2173    +3
Impacted Files Coverage Δ
uplink/arguments.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a68434...792530c. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #169   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          41     41           
  Lines        2170   2173    +3     
  Branches      173    173           
=====================================
+ Hits         2170   2173    +3
Impacted Files Coverage Δ
uplink/arguments.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a68434...792530c. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 10, 2019 •
edited
Loading

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #169   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          41     41           
  Lines        2170   2173    +3     
  Branches      173    173           
=====================================
+ Hits         2170   2173    +3
Impacted Files Coverage Δ
uplink/arguments.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a68434...792530c. Read the comment docs.

@prkumar prkumar merged commit 66e3a5a into master Aug 10, 2019
@prkumar prkumar mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Header variable is always used, even when default is None
1 participant
@prkumar