Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale Bars #10

Closed
2 of 4 tasks
ThomasOrtner opened this issue Feb 16, 2021 · 13 comments
Closed
2 of 4 tasks

Scale Bars #10

ThomasOrtner opened this issue Feb 16, 2021 · 13 comments
Assignees
Labels
enhancement New feature or request
Projects

Comments

@ThomasOrtner
Copy link
Collaborator

ThomasOrtner commented Feb 16, 2021

Add new interaction called "PlaceScaleBar". Generate black and white boxed or cylindrical scale bar of certain height with vertical or horizontal orientation. These properties are to be changed afterwards maybe as length and azimuth (if horizontal). In a later stage they automatically adapt to the zoom factor, changing their length, subdivisions and eventually units. Besides that, their orientation can be set arbitrarily, e.g. by providing Maya controllers (might be reused from other features such as placing scene objects). Martin Riegelnegg's BA can be partly used for this issue. Task seperation:

  • Place vertical or horizontal scalar bar onto surface point
  • Configure properties in the GUI (length, subdivisions)
  • Adaptation to zoom factor
  • Free transform with Maya controllers and/or GUI

Requirement P3D-M004

@ThomasOrtner ThomasOrtner added the enhancement New feature or request label Feb 16, 2021
@chris-traxler chris-traxler changed the title Simple Scale Bars Scale Bars Mar 9, 2021
@chris-traxler chris-traxler added this to To do in Mastcam-Z via automation Mar 9, 2021
@ThomasOrtner
Copy link
Collaborator Author

image

some preliminary designs

@LauraFritz14
Copy link
Collaborator

LauraFritz14 commented Apr 7, 2021

Branch: develop/features/scaleBars
Testdata: Surface: file://euclid.vrvis.lan/InOut/PRo3D/Job-MCZ-Pano-Sol3_opc.zip

ScaleBars

To place a scale bar pick "PlaceScaleBar" in the actions drop down menu. Then you can adjust the settings (A):

  • Orientation: Horizontal: along the camera's right vector, Vertical: along the camera's up vector, Sky: along the camera's sky vector (=the up vektor of the reference system)
  • Pivot: left, middle, right
  • Length
  • and Unit

To place the scale bar point on the surface and press CTRL+LMB

The listing (right) shows all scale bars in the scene. Under the scale bar's name is a little menu (B):

  • FlyTo: triggers a FlyTo animation
  • Toggle Visible: toggles the scale bar visible/invisible
  • Remove: removes the scale bar from the scene

You can select a scale bar by clicking on it's name, which turns the color to green. Then you can see the scale bar's properties in the Properties panel (C):

  • Name: the name in the listing (press enter)
  • Textsize: from the scale bar's text (3d view)
  • Visible: toggles the scale bar visible/invisible
  • Length: the length in the selected unit
  • Thickness: the line thickness
  • Subdivisions: number of subdivisions (alternating black and white)
  • Orientation: Horizontal: along the camera's right vector, Vertical: along the camera's up vector, Sky: along the camera's sky vector (=the up vektor of the reference system)
  • Unit: mm, cm, m, km

@ThomasOrtner ThomasOrtner moved this from To do to In Progress in Mastcam-Z Apr 11, 2021
@chris-traxler
Copy link
Collaborator

chris-traxler commented Apr 15, 2021

All the features described by @LauraFritz14 above were successfully tested.
There is just a small rendering bug: When the thickness becomes too large texture artifacts appear when zooming out. In the firts video, only the thickness of the front most scale bar was not modified.

ScaleBarsZooming_1.mp4
ScaleBarsZooming_2.mp4

@ThomasOrtner
Copy link
Collaborator Author

image

This is strange. The actual design plan was to implement these objects as Sg.boxes or Sg.cylinders. This looks like a "thick line" to me. Switchting this to Sg.Cylinders should alleviate the problem. Also a depth-testing similar to the scene objects would be beneficial.

@LauraFritz14
Copy link
Collaborator

  • changed lines to Sg.Cylinders
  • highest priority rendering for scalebars

@LauraFritz14
Copy link
Collaborator

LauraFritz14 commented Apr 27, 2021

#172: Commit 0a06922 pushed by LauraFritz14

  • changed thickness slider to inputbox
  • scalebars text (3d view) visible/invisible

@chris-traxler
Copy link
Collaborator

I have tested the new version. Everything works fine. The rendering bug described above was fixed. No texture artefacts are visible when zooming out after changing the thickness of scalbars.

@chris-traxler chris-traxler mentioned this issue May 4, 2021
8 tasks
@LauraFritz14 LauraFritz14 mentioned this issue May 20, 2021
12 tasks
@LauraFritz14
Copy link
Collaborator

LauraFritz14 commented Jul 23, 2021

Thanks @gpaar for testing!

  • void obstruction of text and scalebar from the scene triangles. Or - better: Allow a flag for the user to choose. Sometimes it's useful to bury those planks to visualize dunes etc.
  • The new zooming feature causes the text even in its smallest version 0,01 appear huge. It shall go down to 0,001 at least.
  • It is unpredictable whether the text or the scalebar is in front. The text shall always be in front.
  • Please separate the text from the scalebar. Currently they overlap
  • (future desire) For thickness choose per default 1/20 of length
  • (future desire) It would help if the starting point of the scalebar (i.e. where it hits the surface) is marked e.g. as small yellow spot
  • (future) it could help to allow 2 rotation angles, as sometimes one wants to align the scale bar to the edge of a rock etc.

See examples as attached.

143-8151-Scalebars

  • scalebars numeric lässt sich in 0,5 schritten ändern, die anzeige rundet aber auf, hier 1,5cm vs 2 in der eingabe
  • Sometimes the scalebar highlight is too thick so that the scalebar and its subdivisions are not visible.
    image (1)

@LauraFritz14
Copy link
Collaborator

LauraFritz14 commented Aug 1, 2021

Branch: develop/features/scaleBars2
Commit: 282d086
Testdata: Surface: file://euclid.vrvis.lan/InOut/PRo3D/Job-MCZ-Pano-Sol3_opc.zip

This update includes the checked points from the list above.

img

A: priority rendering on/off to disable/allow overlapping of the scale bars by the surface (2m is with and 1m without priority)
B: visible starting point (=pivot) (yellow dot)

LauraFritz14 added a commit that referenced this issue Aug 1, 2021
@chris-traxler
Copy link
Collaborator

I observed a usability issue. Sometimes the scalebar highlight is too thick so that the scalebar and its subdivisions are not visible.
image

@gpaar
Copy link
Collaborator

gpaar commented Aug 3, 2021 via email

@LauraFritz14
Copy link
Collaborator

LauraFritz14 commented Aug 26, 2021

Branch: develop/features/scaleBars2
Commit: 1bd55a3
Testdata: Surface: file://euclid.vrvis.lan/InOut/PRo3D/Job-MCZ-Pano-Sol3_opc.zip

This update includes the pending points from the list above:

  • It is unpredictable whether the text or the scalebar is in front. The text shall always be in front.
  • Sometimes the scalebar highlight is too thick so that the scalebar and its subdivisions are not visible.
  • (future) it could help to allow 2 rotation angles, as sometimes one wants to align the scale bar to the edge of a rock etc.

@ThomasOrtner ThomasOrtner moved this from In Progress to Done in Mastcam-Z Oct 28, 2021
@chris-traxler
Copy link
Collaborator

The open tasks were transferred to the newer issue #125 and described in more detail there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants