Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces Adaptify.MSBuild with explicit adaptify invocation #273

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

haraldsteinlechner
Copy link
Collaborator

This PR changes the mode of operation for automatically generated model types. Instead of having the compilation integrated in the normal build process, here adaptify compilation needs to be triggered manually (see https://github.com/krauthaufen/Adaptify/blob/features/addGFilesToProject/README.md#local-mode).
The idea is to have better compile times, a more responsive IDE and better support for using vscode and other non-visual-studio tools.
The drawback is, that whenever a model type gets changed, a script need to be run to patch all automatically generated code.

At this stage, we are testing out the tradeoffs. I added @LauraFritz14 and @RebeccaNowak as reviewers for this PR - please test the branch in terms of development experience.

  • compile everything using the adaptify tool
  • ask for feedback
  • change the docs accordingly

…daptifyWithoutMsBuild

# Conflicts:
#	global.json
#	src/PRo3D.Core/PRo3D.Core.fsproj
@RebeccaNowak
Copy link
Collaborator

Tried out calling dotnet adaptify --local --force --lenses --addToProject project.fsproj to generate correct .g files, which worked. Not sure about compile time / responsiveness yet, need to test it some more. @haraldsteinlechner is it normal that the adaptify process still runs in the background?

@haraldsteinlechner
Copy link
Collaborator Author

@RebeccaNowak actually i removed the adaptify msbuild references in the projects - d74f6f3
this means - also the msbuild targets should have been removed => thus, no adaptify should be invoked. of course another old instance could have left a lurking adaptify in daemon mode (running in background, waiting for compile requests).
In the end we would commit all .g files, and the patched projects - only when changing model files, the tool needs to be invoked to update the .g files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants