Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preconditioner #166

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Conversation

pnkraemer
Copy link
Collaborator

These are the changes that we discussed in person 2 weeks ago @nathanaelbosch. In summary:

  • default preconditioner is [h^(-q), h^(-q+1), ..., 1] instead of [1, h, ..., h^q]
  • a test is added that makes sure that step h=1e-5 and order q=3 work with a smoother (this was not possible before!)
  • the documentation in prior.py is updated. The doctest that needed fixing 2 weeks ago magically works now...

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #166 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   73.32%   73.32%           
=======================================
  Files          57       57           
  Lines        3040     3040           
  Branches      391      391           
=======================================
  Hits         2229     2229           
  Misses        660      660           
  Partials      151      151           
Impacted Files Coverage Δ
src/probnum/diffeq/odefiltsmooth/prior.py 95.04% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c0c0cf...4c83e5f. Read the comment docs.

Copy link
Collaborator

@nathanaelbosch nathanaelbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

But the pylint check currently fails, even though locally it seems fine. Do you have any idea on why this is happening?

src/probnum/diffeq/odefiltsmooth/prior.py Outdated Show resolved Hide resolved
@pnkraemer
Copy link
Collaborator Author

The lint fails in prob. Maybe something to do with pytest-dev/pytest-qt#170? I dont know enough about tox about this. THe same problem came up in #167 but since prob is bound for refactoring anyway, maybe we merge anyway?

@JonathanWenger
Copy link
Contributor

After Nathanael's fix #171 linting works now.

@pnkraemer pnkraemer merged commit 8779648 into probabilistic-numerics:master Aug 25, 2020
@pnkraemer pnkraemer deleted the new_precond branch November 13, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants