Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up quad api #739

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Conversation

mmahsereci
Copy link
Contributor

In a Nutshell

This PR cleans up the quad api structure and the docs (see linked issue)

Detailed Description

n.a.

Related Issues

Closes #574

@mmahsereci mmahsereci requested a review from a team as a code owner November 17, 2022 16:41
@mmahsereci mmahsereci self-assigned this Nov 17, 2022
@mmahsereci mmahsereci added documentation Improvements or additions to documentation quad Issues related to quadrature labels Nov 17, 2022
@mmahsereci mmahsereci added this to In progress in ProbNum Development via automation Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #739 (78c5280) into main (35f50e4) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   90.46%   90.48%   +0.02%     
==========================================
  Files         198      199       +1     
  Lines        7498     7516      +18     
  Branches      974      974              
==========================================
+ Hits         6783     6801      +18     
  Misses        481      481              
  Partials      234      234              
Impacted Files Coverage Δ
src/probnum/quad/__init__.py 100.00% <100.00%> (ø)
src/probnum/quad/_bayesquad.py 100.00% <100.00%> (ø)
src/probnum/quad/_utils.py 93.54% <100.00%> (+0.21%) ⬆️
src/probnum/quad/integration_measures/__init__.py 100.00% <100.00%> (ø)
...quad/integration_measures/_integration_measures.py 100.00% <100.00%> (ø)
src/probnum/quad/kernel_embeddings/__init__.py 100.00% <100.00%> (ø)
...c/probnum/quad/kernel_embeddings/_expquad_gauss.py 100.00% <100.00%> (ø)
...robnum/quad/kernel_embeddings/_expquad_lebesgue.py 100.00% <100.00%> (ø)
...robnum/quad/kernel_embeddings/_kernel_embedding.py 89.28% <100.00%> (ø)
...probnum/quad/kernel_embeddings/_matern_lebesgue.py 100.00% <100.00%> (ø)
... and 15 more

ProbNum Development automation moved this from In progress to Review in progress Nov 18, 2022
Copy link
Contributor

@JonathanWenger JonathanWenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking care of the module structure and docs!

@mmahsereci mmahsereci merged commit 7a71330 into probabilistic-numerics:main Nov 18, 2022
ProbNum Development automation moved this from Review in progress to Done Nov 18, 2022
@mmahsereci mmahsereci deleted the mm-quad-api branch November 18, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation quad Issues related to quadrature
Projects
Development

Successfully merging this pull request may close these issues.

BQ API references could be more user friendly
2 participants