Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make quad integration measures stateless #748

Merged

Conversation

mmahsereci
Copy link
Contributor

In a Nutshell

This PR removes the default rng from the quad integration measures. Further, some long overdue shape tests for the sample method of the measures are added.

Detailed Description

na

Related Issues

Closes #...

@mmahsereci mmahsereci marked this pull request as draft December 5, 2022 15:04
@mmahsereci mmahsereci self-assigned this Dec 5, 2022
@mmahsereci mmahsereci added the quad Issues related to quadrature label Dec 5, 2022
@mmahsereci mmahsereci added this to In progress in ProbNum Development via automation Dec 5, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #748 (75d4d48) into main (d94ff24) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
+ Coverage   90.69%   90.71%   +0.02%     
==========================================
  Files         206      206              
  Lines        7638     7638              
  Branches      982      982              
==========================================
+ Hits         6927     6929       +2     
+ Misses        479      478       -1     
+ Partials      232      231       -1     
Impacted Files Coverage Δ
.../quad/integration_measures/_integration_measure.py 100.00% <ø> (ø)
...num/quad/integration_measures/_lebesgue_measure.py 100.00% <ø> (ø)
src/probnum/quad/_utils.py 100.00% <100.00%> (+6.45%) ⬆️

@mmahsereci mmahsereci marked this pull request as ready for review December 5, 2022 17:37
Copy link
Collaborator

@tskarvone tskarvone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. As a user, I personally find it a bit annoying to have to provide an rng myself, but there is probably a good reason for this change.

ProbNum Development automation moved this from In progress to Review in progress Dec 9, 2022
@mmahsereci
Copy link
Contributor Author

Looks good to me. As a user, I personally find it a bit annoying to have to provide an rng myself, but there is probably a good reason for this change.

It's mostly in preparation for #581 . See #744 (comment)

@mmahsereci mmahsereci merged commit 90b5dd3 into probabilistic-numerics:main Dec 9, 2022
ProbNum Development automation moved this from Review in progress to Done Dec 9, 2022
@mmahsereci mmahsereci deleted the mm-quad-stateless-measures branch December 9, 2022 16:26
@mmahsereci mmahsereci restored the mm-quad-stateless-measures branch December 9, 2022 16:49
mmahsereci added a commit that referenced this pull request Dec 9, 2022
@mmahsereci
Copy link
Contributor Author

The tox docs build seems to have failed when merging into main. I am not reverting though as the RTD build seems fine. Don't have time too look into it right away unfortunately. pinging @JonathanWenger for info.

@mmahsereci mmahsereci deleted the mm-quad-stateless-measures branch December 14, 2022 12:56
@JonathanWenger
Copy link
Contributor

@mmahsereci Should be fixed now in #754 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quad Issues related to quadrature
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants