Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor global pylint checks #788

Merged

Conversation

marvinpfoertner
Copy link
Collaborator

In a Nutshell

This PR refactors the global pylint check run on in ProbNum's CI.

Detailed Description

  • upgrade the pylint version to 2.16.*
  • fix all pylint messages in randprocs (except in randprocs.markov)
  • fix all pylint messages in utils
  • fix all pylint messages in _config.py
  • enable all messages in global linting pass but exclude the packages, which still need disabled messages
  • force parameters, return types, yield types and exceptions to be documented in function docstrings

Related Issues

None

@marvinpfoertner marvinpfoertner added the testing and CI Unit tests, coverage and continuous integration label Feb 17, 2023
@marvinpfoertner marvinpfoertner self-assigned this Feb 17, 2023
@marvinpfoertner marvinpfoertner added this to In progress in ProbNum Development via automation Feb 17, 2023
@marvinpfoertner marvinpfoertner removed the request for review from pnkraemer February 17, 2023 16:46
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #788 (8dc9a63) into main (6c69825) will increase coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #788   +/-   ##
=======================================
  Coverage   91.20%   91.20%           
=======================================
  Files         215      215           
  Lines        8058     8062    +4     
  Branches     1021     1021           
=======================================
+ Hits         7349     7353    +4     
  Misses        482      482           
  Partials      227      227           
Impacted Files Coverage Δ
src/probnum/linops/_arithmetic_fallbacks.py 86.84% <0.00%> (ø)
src/probnum/randprocs/kernels/_arithmetic.py 100.00% <ø> (ø)
...probnum/randprocs/kernels/_arithmetic_fallbacks.py 82.05% <0.00%> (ø)
src/probnum/utils/argutils.py 100.00% <ø> (ø)
src/probnum/utils/linalg/_cholesky_updates.py 100.00% <ø> (ø)
src/probnum/randprocs/kernels/_kernel.py 93.82% <75.00%> (ø)
src/probnum/linops/_linear_operator.py 86.99% <80.00%> (ø)
src/probnum/_config.py 92.00% <100.00%> (+0.33%) ⬆️
src/probnum/conftest.py 100.00% <100.00%> (ø)
src/probnum/functions/_function.py 96.61% <100.00%> (ø)
... and 6 more

Copy link
Contributor

@JonathanWenger JonathanWenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'm all for simplifying the CI.

ProbNum Development automation moved this from In progress to Review in progress Feb 17, 2023
@marvinpfoertner marvinpfoertner merged commit 3c69e3b into probabilistic-numerics:main Feb 17, 2023
ProbNum Development automation moved this from Review in progress to Done Feb 17, 2023
@marvinpfoertner marvinpfoertner deleted the pylint-refactor branch February 17, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing and CI Unit tests, coverage and continuous integration
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants