Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refer to auxiliary randomness r more consistently. #492

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

fsaad
Copy link
Collaborator

@fsaad fsaad commented Dec 14, 2022

  1. Use p(r | t; x) to denote the conditional of p(r, t; x) rather than p(r; x, t). The current notation does not make it clear that p(r; x, t) must coincide with the proper conditional (r | t; x), according to Bayes rule.

  2. Use p(r,t;x) throughout, rather than the current mix of p(t,r;x) and p(r,t;x).

1. Use p(r | t; x) to denote the conditional of p(r, t; x) rather than
p(r; x, t).  The current notation does not make it clear that p(r; x, t)
must coincide with the proper conditional (r | t; x), according to Bayes rule.

2. Use p(r,t;x) throughout, rather than the current mix of
p(t,r;x) and p(r,t;x).
@fsaad fsaad requested a review from ztangent December 14, 2022 16:48
Copy link
Member

@ztangent ztangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@ztangent ztangent merged commit 6943027 into master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants