Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type signature of HeterogeneousMixture, Closes #500 #501

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

mirkoklukas
Copy link
Contributor

@mirkoklukas mirkoklukas commented Feb 15, 2023

Closes #500

You couldn't call HeterogeneousMixture on a vector of type Vector{D}, where D inherited from Distributions{T}. This should fix it.

You couldn't call `HeterogeneousMixture` on a vector of type `Vector{D}`, where `D` inherited from `Distributions{T}`. This should fix it.
@mirkoklukas mirkoklukas changed the title Changed to more flexible type signature Type signature of HeterogeneousMixture, Closes #10 Feb 15, 2023
@mirkoklukas mirkoklukas changed the title Type signature of HeterogeneousMixture, Closes #10 Type signature of HeterogeneousMixture, Closes #500 Feb 15, 2023
@mirkoklukas mirkoklukas marked this pull request as ready for review February 15, 2023 11:58
@alex-lew
Copy link
Contributor

Sorry I missed this! Looks good to me!

@alex-lew alex-lew merged commit 262f96f into probcomp:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type signature of HeterogeneousMixture
2 participants