Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crosscat misappropriates entropy from numpy #56

Closed
riastradh-probcomp opened this issue Sep 24, 2015 · 3 comments
Closed

crosscat misappropriates entropy from numpy #56

riastradh-probcomp opened this issue Sep 24, 2015 · 3 comments

Comments

@riastradh-probcomp
Copy link
Contributor

simple_predictive_sample_unobserved calls numpy.random.multinomial with no specified seed, so numpy presumably draws it from the environment.

@fsaad
Copy link
Collaborator

fsaad commented Sep 24, 2015

This is probably an issue, but notice that simple_predictive_sample when invoked through simple_predictive_sample_multistate, does have the numpy seed managed
https://github.com/probcomp/crosscat/blob/master/crosscat/utils/sample_utils.py#L257
The problem is when we invoke simple_predictive_sample externally -- which only happens when the
crosscat instance has 1 model (which is rarely the case, and why I think the effects of the bug have not been witnessed).

@riastradh-probcomp
Copy link
Contributor Author

Unrelated. That random state is correctly deterministically derived from the user-specified seed; the one ine simple_predictive_sample_*unobserved* is not.

@axch
Copy link
Contributor

axch commented Nov 2, 2015

Fixed by e5bab7a .

@axch axch closed this as completed Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants