Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Callback DataStream #13

Merged
merged 18 commits into from
Jun 3, 2024
Merged

Conversation

samcm
Copy link
Contributor

@samcm samcm commented Apr 16, 2024

  • Adds a new callback DataStream that implements the DataStream interface similar Kinesis
    • Allows other Go projects to start a Hermes Node instance directly and to receive events.
    • Unsure if we want to generalize it even further with some config to toggle which DataStream's are enabled. At the moment it's toggled by the existence of aws config.
  • Makes the RpcMeta structs public for easy consumption in other Go projects

Related Xatu integration: ethpandaops/xatu#297

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Contributor

@guillaumemichel guillaumemichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far. @cortze may also want to provide a review as he may be more familiar with the implementation.

@samcm let us know here once the PR is ready :)

@samcm samcm changed the title draft: Feat: Add Callback DataStream feat: Add Callback DataStream May 27, 2024
@samcm
Copy link
Contributor Author

samcm commented May 27, 2024

Thanks @guillaumemichel! This one is ready for review I think. I've tested it against a localstack Kinesis and it looked ok but I've never really used Kinesis before so not entirely sure what to test against. I could produce/consume messages at least. cc @cortze 🙏

Copy link
Contributor

@cortze cortze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was able to run it, and it was submitting traces to AWS Kinesis without any problem.

I can take care of anything missing if needed :)

host/kinesis.go Outdated Show resolved Hide resolved
samcm and others added 3 commits June 3, 2024 11:07
Co-authored-by: Mikel Cortes <45786396+cortze@users.noreply.github.com>
@samcm samcm requested a review from cortze June 3, 2024 01:12
@samcm
Copy link
Contributor Author

samcm commented Jun 3, 2024

Should be all good now @cortze, thank you!

@cortze cortze merged commit a050845 into probe-lab:main Jun 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants