-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Callback DataStream #13
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guillaumemichel! This one is ready for review I think. I've tested it against a localstack Kinesis and it looked ok but I've never really used Kinesis before so not entirely sure what to test against. I could produce/consume messages at least. cc @cortze 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I was able to run it, and it was submitting traces to AWS Kinesis without any problem.
I can take care of anything missing if needed :)
Co-authored-by: Mikel Cortes <45786396+cortze@users.noreply.github.com>
Merge upstream
Should be all good now @cortze, thank you! |
callback
DataStream that implements theDataStream
interface similarKinesis
Node
instance directly and to receive events.DataStream
's are enabled. At the moment it's toggled by the existence of aws config.RpcMeta
structs public for easy consumption in other Go projectsRelated Xatu integration: ethpandaops/xatu#297